[css-grid] Implement repeat(auto-fit)

third_party/WebKit/Source/core/style/GridArea.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 129 matching lines @@
         ASSERT(m_type == UntranslatedDefinite);
 
         m_type = TranslatedDefinite;
         m_startLine += offset;
         m_endLine += offset;
 
         ASSERT(m_startLine >= 0);
         ASSERT(m_endLine > 0);
     }
 
+    void adjustForDroppedTracks(size_t numDroppedTracks);

[Manuel Rego, 2016/06/21 21:57:38]

Why the implementation is not here like for the rest of the class?

Nit: I'd rename the argument to droppedTracksCount or simply droppedTracks.

[svillar, 2016/06/23 08:09:42]

Because it's kind of a non-written rule of the project, if the implementation is
not a one liner, it's better to have the implementation inlined. This way the
API of the class is much cleaner.

+
 private:
 
     enum GridSpanType {UntranslatedDefinite, TranslatedDefinite, Indefinite};
 
     GridSpan(int startLine, int endLine, GridSpanType type)
         : m_type(type)
     {
 #if ENABLE(ASSERT)
         ASSERT(startLine < endLine);
         if (type == TranslatedDefinite) {
@@ skipping 11 matching lines @@
             m_endLine = std::min(endLine, kGridMaxTracks);
         else
             m_endLine = std::max(endLine, -kGridMaxTracks + 1);
     }
 
     int m_startLine;
     int m_endLine;
     GridSpanType m_type;
 };
 
+void inline GridSpan::adjustForDroppedTracks(size_t numDroppedTracks)
+{
+    DCHECK(isTranslatedDefinite());
+    DCHECK_GE(static_cast<size_t>(m_startLine), numDroppedTracks);

[Manuel Rego, 2016/06/21 21:57:38]

You can use startLine() to avoid the manual cast here.

[svillar, 2016/06/23 08:09:43]

awesome

+    DCHECK_GE(static_cast<size_t>(m_endLine), numDroppedTracks);

[Manuel Rego, 2016/06/21 21:57:38]

m_endLine is always greater than m_startLine,
so this doesn't seem needed.

Anyway we can keep it, but probably using endLine() too.

[svillar, 2016/06/23 08:09:43]

Acknowledged.

+    m_startLine -= numDroppedTracks;
+    m_endLine -= numDroppedTracks;
+}
+
 // This represents a grid area that spans in both rows' and columns' direction.
 struct GridArea {
     USING_FAST_MALLOC(GridArea);
 public:
     // HashMap requires a default constuctor.
     GridArea()
         : columns(GridSpan::indefiniteGridSpan())
         , rows(GridSpan::indefiniteGridSpan())
     {
     }
 
     GridArea(const GridSpan& r, const GridSpan& c)
         : columns(c)
         , rows(r)
     {
     }
 
     bool operator==(const GridArea& o) const
     {
         return columns == o.columns && rows == o.rows;
     }
 
     bool operator!=(const GridArea& o) const
     {
         return !(*this == o);
     }
 
+    void adjustForDroppedTracks(size_t numDroppedColumns, size_t numDroppedRows);

[Manuel Rego, 2016/06/21 21:57:38]

Ditto.

+
     GridSpan columns;
     GridSpan rows;
 };
 
+void inline GridArea::adjustForDroppedTracks(size_t numDroppedColumns, size_t numDroppedRows)
+{
+    if (numDroppedColumns)
+        columns.adjustForDroppedTracks(numDroppedColumns);
+    if (numDroppedRows)
+        rows.adjustForDroppedTracks(numDroppedRows);
+}
+
 typedef HashMap<String, GridArea> NamedGridAreaMap;
 
 } // namespace blink
 
 #endif // GridArea_h