Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 2080633004: Subzero: Make liveness validation errors easier to interpret. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceTargetLoweringX86BaseImpl.h - x86 lowering -*- C++ -*-==// 1 //===- subzero/src/IceTargetLoweringX86BaseImpl.h - x86 lowering -*- C++ -*-==//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 516
517 // Register allocation. This requires instruction renumbering and full 517 // Register allocation. This requires instruction renumbering and full
518 // liveness analysis. Loops must be identified before liveness so variable 518 // liveness analysis. Loops must be identified before liveness so variable
519 // use weights are correct. 519 // use weights are correct.
520 Func->renumberInstructions(); 520 Func->renumberInstructions();
521 if (Func->hasError()) 521 if (Func->hasError())
522 return; 522 return;
523 Func->liveness(Liveness_Intervals); 523 Func->liveness(Liveness_Intervals);
524 if (Func->hasError()) 524 if (Func->hasError())
525 return; 525 return;
526 // The post-codegen dump is done here, after liveness analysis and associated
527 // cleanup, to make the dump cleaner and more useful.
528 Func->dump("After initial x8632 codegen");
526 // Validate the live range computations. The expensive validation call is 529 // Validate the live range computations. The expensive validation call is
527 // deliberately only made when assertions are enabled. 530 // deliberately only made when assertions are enabled.
528 assert(Func->validateLiveness()); 531 assert(Func->validateLiveness());
529 // The post-codegen dump is done here, after liveness analysis and associated
530 // cleanup, to make the dump cleaner and more useful.
531 Func->dump("After initial x8632 codegen");
532 Func->getVMetadata()->init(VMK_All); 532 Func->getVMetadata()->init(VMK_All);
533 regAlloc(RAK_Global); 533 regAlloc(RAK_Global);
534 if (Func->hasError()) 534 if (Func->hasError())
535 return; 535 return;
536 Func->dump("After linear scan regalloc"); 536 Func->dump("After linear scan regalloc");
537 537
538 if (getFlags().getEnablePhiEdgeSplit()) { 538 if (getFlags().getEnablePhiEdgeSplit()) {
539 Func->advancedPhiLowering(); 539 Func->advancedPhiLowering();
540 Func->dump("After advanced Phi lowering"); 540 Func->dump("After advanced Phi lowering");
541 } 541 }
(...skipping 7428 matching lines...) Expand 10 before | Expand all | Expand 10 after
7970 emitGlobal(*Var, SectionSuffix); 7970 emitGlobal(*Var, SectionSuffix);
7971 } 7971 }
7972 } 7972 }
7973 } break; 7973 } break;
7974 } 7974 }
7975 } 7975 }
7976 } // end of namespace X86NAMESPACE 7976 } // end of namespace X86NAMESPACE
7977 } // end of namespace Ice 7977 } // end of namespace Ice
7978 7978
7979 #endif // SUBZERO_SRC_ICETARGETLOWERINGX86BASEIMPL_H 7979 #endif // SUBZERO_SRC_ICETARGETLOWERINGX86BASEIMPL_H
OLDNEW
« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698