Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js

Issue 2080633002: DevTools: render markers as circles on the main timeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 markerIndices[nextMarkerIndex++] = entryIndex; 1303 markerIndices[nextMarkerIndex++] = entryIndex;
1304 } else { 1304 } else {
1305 context.rect(barX, barY, barWidth - 0.4, barHeight - 1); 1305 context.rect(barX, barY, barWidth - 0.4, barHeight - 1);
1306 if (barWidth > minTextWidth || this._dataProvider.forceDecor ation(entryIndex)) 1306 if (barWidth > minTextWidth || this._dataProvider.forceDecor ation(entryIndex))
1307 titleIndices[nextTitleIndex++] = entryIndex; 1307 titleIndices[nextTitleIndex++] = entryIndex;
1308 } 1308 }
1309 } 1309 }
1310 context.fill(); 1310 context.fill();
1311 } 1311 }
1312 1312
1313 context.strokeStyle = "rgb(0, 0, 0)"; 1313 context.strokeStyle = "rgba(0, 0, 0, 0.2)";
1314 context.beginPath(); 1314 context.beginPath();
1315 for (var m = 0; m < nextMarkerIndex; ++m) { 1315 for (var m = 0; m < nextMarkerIndex; ++m) {
1316 var entryIndex = markerIndices[m]; 1316 var entryIndex = markerIndices[m];
1317 var entryStartTime = entryStartTimes[entryIndex]; 1317 var entryStartTime = entryStartTimes[entryIndex];
1318 var barX = this._timeToPositionClipped(entryStartTime); 1318 var barX = this._timeToPositionClipped(entryStartTime);
1319 var barLevel = entryLevels[entryIndex]; 1319 var barLevel = entryLevels[entryIndex];
1320 var barY = this._levelToHeight(barLevel); 1320 var barY = this._levelToHeight(barLevel);
1321 context.moveTo(barX + this._markerRadius, barY + barHeight / 2); 1321 context.moveTo(barX + this._markerRadius, barY + barHeight / 2);
1322 context.arc(barX, barY + barHeight / 2, this._markerRadius, 0, Math. PI * 2); 1322 context.arc(barX, barY + barHeight / 2, this._markerRadius, 0, Math. PI * 2);
1323 } 1323 }
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
2019 this.update(); 2019 this.update();
2020 }, 2020 },
2021 2021
2022 _enabled: function() 2022 _enabled: function()
2023 { 2023 {
2024 return this._rawTimelineDataLength !== 0; 2024 return this._rawTimelineDataLength !== 0;
2025 }, 2025 },
2026 2026
2027 __proto__: WebInspector.HBox.prototype 2027 __proto__: WebInspector.HBox.prototype
2028 } 2028 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698