Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2080633002: DevTools: render markers as circles on the main timeline. (Closed)

Created:
4 years, 6 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: render markers as circles on the main timeline. BUG=619594 Committed: https://crrev.com/7906a007c41fccf1b0576193494c1f5f5147cf85 Cr-Commit-Position: refs/heads/master@{#402175}

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : only render circles for markers. #

Patch Set 4 : rebaselined tests #

Messages

Total messages: 19 (9 generated)
pfeldman
4 years, 6 months ago (2016-06-20 10:03:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080633002/20001
4 years, 6 months ago (2016-06-20 10:50:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 12:32:36 UTC) #6
caseq
lgtm, though we should eventually find a better rendering for an instant event to make ...
4 years, 6 months ago (2016-06-21 09:42:55 UTC) #7
pfeldman
PTAL
4 years, 6 months ago (2016-06-21 10:55:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080633002/40001
4 years, 6 months ago (2016-06-21 10:56:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/249618)
4 years, 6 months ago (2016-06-21 12:11:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080633002/60001
4 years, 5 months ago (2016-06-27 13:25:37 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 14:40:32 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 14:42:35 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7906a007c41fccf1b0576193494c1f5f5147cf85
Cr-Commit-Position: refs/heads/master@{#402175}

Powered by Google App Engine
This is Rietveld 408576698