Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 208063002: Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M src/elements.cc View 19 chunks +46 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-21 11:42:00 UTC) #1
Yang
On 2014/03/21 11:42:00, Igor Sheludko wrote: > PTAL lgtm.
6 years, 9 months ago (2014-03-24 08:23:37 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-03-24 09:06:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698