third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp ('k') | third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

diff --git a/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

index bc5b15b42161526deab638629d44185f93e9e156..9cc309c85810acdb5c70fd9d45789df30c9e178b 100644

--- a/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

+++ b/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h

@@ -37,7 +37,6 @@

#include "public/platform/WebScheduler.h"

#include "public/platform/WebThread.h"

#include "wtf/Vector.h"

-#include <memory>

namespace blink {

@@ -75,8 +74,8 @@ public:

void onNavigationStarted() override { }

private:

- WTF::Deque<std::unique_ptr<WebTaskRunner::Task>> m_tasks;

- std::unique_ptr<TestingPlatformMockWebTaskRunner> m_mockWebTaskRunner;

+ WTF::Deque<OwnPtr<WebTaskRunner::Task>> m_tasks;

+ OwnPtr<TestingPlatformMockWebTaskRunner> m_mockWebTaskRunner;

};

class TestingPlatformSupport : public Platform {

@@ -113,7 +112,7 @@ public:

TestingPlatformMockScheduler* mockWebScheduler();

protected:

- std::unique_ptr<TestingPlatformMockWebThread> m_mockWebThread;

+ OwnPtr<TestingPlatformMockWebThread> m_mockWebThread;

};

} // namespace blink