Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
diff --git a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
index 6ff989db99a5205db5e1e97c90d6dd2c29b5f8ce..2ab2e785551d6a83528be84b6cd53c41baaa6bd8 100644
--- a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
+++ b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
@@ -46,9 +46,7 @@
#include "platform/TraceEvent.h"
#include "public/platform/WebMediaSource.h"
#include "public/platform/WebSourceBuffer.h"
-#include "wtf/PtrUtil.h"
#include "wtf/text/CString.h"
-#include <memory>
using blink::WebMediaSource;
using blink::WebSourceBuffer;
@@ -150,7 +148,7 @@ SourceBuffer* MediaSource::addSourceBuffer(const String& type, ExceptionState& e
// 5. Create a new SourceBuffer object and associated resources.
ContentType contentType(type);
String codecs = contentType.parameter("codecs");
- std::unique_ptr<WebSourceBuffer> webSourceBuffer = createWebSourceBuffer(contentType.type(), codecs, exceptionState);
+ OwnPtr<WebSourceBuffer> webSourceBuffer = createWebSourceBuffer(contentType.type(), codecs, exceptionState);
if (!webSourceBuffer) {
DCHECK(exceptionState.code() == NotSupportedError || exceptionState.code() == QuotaExceededError);
@@ -287,7 +285,7 @@ DEFINE_TRACE(MediaSource)
ActiveDOMObject::trace(visitor);
}
-void MediaSource::setWebMediaSourceAndOpen(std::unique_ptr<WebMediaSource> webMediaSource)
+void MediaSource::setWebMediaSourceAndOpen(PassOwnPtr<WebMediaSource> webMediaSource)
{
TRACE_EVENT_ASYNC_END0("media", "MediaSource::attachToElement", this);
DCHECK(webMediaSource);
@@ -579,13 +577,13 @@ void MediaSource::stop()
m_webMediaSource.reset();
}
-std::unique_ptr<WebSourceBuffer> MediaSource::createWebSourceBuffer(const String& type, const String& codecs, ExceptionState& exceptionState)
+PassOwnPtr<WebSourceBuffer> MediaSource::createWebSourceBuffer(const String& type, const String& codecs, ExceptionState& exceptionState)
{
WebSourceBuffer* webSourceBuffer = 0;
switch (m_webMediaSource->addSourceBuffer(type, codecs, &webSourceBuffer)) {
case WebMediaSource::AddStatusOk:
- return wrapUnique(webSourceBuffer);
+ return adoptPtr(webSourceBuffer);
case WebMediaSource::AddStatusNotSupported:
DCHECK(!webSourceBuffer);
// 2.2 https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type

Powered by Google App Engine
This is Rietveld 408576698