third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp b/third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp

index 196d623f2e0b88d6f1c696246728ab9f3f6ed827..3faad0291eb56fb22ed359fdd00f56b360d75d12 100644

--- a/third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp

+++ b/third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp

@@ -34,7 +34,6 @@

#include "core/testing/DummyPageHolder.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include <memory>

namespace blink {

@@ -62,8 +61,8 @@ protected:

MockActiveDOMObject& activeDOMObject() { return *m_activeDOMObject; }

private:

- std::unique_ptr<DummyPageHolder> m_srcPageHolder;

- std::unique_ptr<DummyPageHolder> m_destPageHolder;

+ OwnPtr<DummyPageHolder> m_srcPageHolder;

+ OwnPtr<DummyPageHolder> m_destPageHolder;

Persistent<MockActiveDOMObject> m_activeDOMObject;

};