third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

index f938343dcf0bc0eae07178cf4f3fdeb7b8c5ae13..b44eb4033cd4073c19683011113102bf73036201 100644

--- a/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp

@@ -12,8 +12,6 @@

#include "core/css/resolver/TransformBuilder.h"

#include "platform/transforms/TransformOperations.h"

#include "platform/transforms/TranslateTransformOperation.h"

-#include "wtf/PtrUtil.h"

-#include <memory>

namespace blink {

@@ -109,9 +107,9 @@ InterpolationValue convertTransform(const TransformOperations& transform)

class InheritedTransformChecker : public InterpolationType::ConversionChecker {

public:

- static std::unique_ptr<InheritedTransformChecker> create(const TransformOperations& inheritedTransform)

+ static PassOwnPtr<InheritedTransformChecker> create(const TransformOperations& inheritedTransform)

{

- return wrapUnique(new InheritedTransformChecker(inheritedTransform));

+ return adoptPtr(new InheritedTransformChecker(inheritedTransform));

}

bool isValid(const InterpolationEnvironment& environment, const InterpolationValue& underlying) const final

@@ -162,7 +160,7 @@ InterpolationValue CSSTransformInterpolationType::maybeConvertValue(const CSSVal

primitiveValue.accumulateLengthArray(lengthArray);

}

- std::unique_ptr<InterpolationType::ConversionChecker> lengthUnitsChecker = LengthUnitsChecker::maybeCreate(std::move(lengthArray), state);

+ OwnPtr<InterpolationType::ConversionChecker> lengthUnitsChecker = LengthUnitsChecker::maybeCreate(std::move(lengthArray), state);

if (lengthUnitsChecker)

conversionCheckers.append(std::move(lengthUnitsChecker));