Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
index a339b1ecd5c3102b53769531af7d2b6cc6702c4a..0ddba0876bf03612e5aa0f1a500d4282447179f0 100644
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
@@ -20,7 +20,6 @@
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/blob/BlobData.h"
#include "platform/network/EncodedFormData.h"
-#include <memory>
namespace blink {
@@ -98,7 +97,7 @@ private:
Member<FetchDataLoader::Client> m_client;
};
-BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState, std::unique_ptr<FetchDataConsumerHandle> handle)
+BodyStreamBuffer::BodyStreamBuffer(ScriptState* scriptState, PassOwnPtr<FetchDataConsumerHandle> handle)
: UnderlyingSourceBase(scriptState)
, m_scriptState(scriptState)
, m_handle(std::move(handle))
@@ -215,7 +214,7 @@ void BodyStreamBuffer::startLoading(FetchDataLoader* loader, FetchDataLoader::Cl
{
ASSERT(!m_loader);
ASSERT(m_scriptState->contextIsValid());
- std::unique_ptr<FetchDataConsumerHandle> handle = releaseHandle();
+ OwnPtr<FetchDataConsumerHandle> handle = releaseHandle();
m_loader = loader;
loader->start(handle.get(), new LoaderClient(m_scriptState->getExecutionContext(), this, client));
}
@@ -235,8 +234,8 @@ void BodyStreamBuffer::tee(BodyStreamBuffer** branch1, BodyStreamBuffer** branch
*branch2 = new BodyStreamBuffer(m_scriptState.get(), stream2);
return;
}
- std::unique_ptr<FetchDataConsumerHandle> handle = releaseHandle();
- std::unique_ptr<FetchDataConsumerHandle> handle1, handle2;
+ OwnPtr<FetchDataConsumerHandle> handle = releaseHandle();
+ OwnPtr<FetchDataConsumerHandle> handle1, handle2;
DataConsumerTee::create(m_scriptState->getExecutionContext(), std::move(handle), &handle1, &handle2);
*branch1 = new BodyStreamBuffer(m_scriptState.get(), std::move(handle1));
*branch2 = new BodyStreamBuffer(m_scriptState.get(), std::move(handle2));
@@ -450,7 +449,7 @@ void BodyStreamBuffer::stopLoading()
m_loader = nullptr;
}
-std::unique_ptr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()
+PassOwnPtr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()
{
DCHECK(!isStreamLocked());
DCHECK(!isStreamDisturbed());
@@ -470,7 +469,7 @@ std::unique_ptr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle()
// We need to call these before calling closeAndLockAndDisturb.
const bool isClosed = isStreamClosed();
const bool isErrored = isStreamErrored();
- std::unique_ptr<FetchDataConsumerHandle> handle = std::move(m_handle);
+ OwnPtr<FetchDataConsumerHandle> handle = std::move(m_handle);
closeAndLockAndDisturb();

Powered by Google App Engine
This is Rietveld 408576698