third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp

index 2413ec3d72192f3022323b872e6c22be36a6b10c..b4fcff9172767b7b6218f2720a05de7b8866bb1b 100644

--- a/third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp

@@ -6,13 +6,12 @@

#include "core/animation/InterpolationEnvironment.h"

#include "core/svg/SVGNumberOptionalNumber.h"

-#include <memory>

namespace blink {

InterpolationValue SVGNumberOptionalNumberInterpolationType::maybeConvertNeutral(const InterpolationValue&, ConversionCheckers&) const

{

- std::unique_ptr<InterpolableList> result = InterpolableList::create(2);

+ OwnPtr<InterpolableList> result = InterpolableList::create(2);

result->set(0, InterpolableNumber::create(0));

result->set(1, InterpolableNumber::create(0));

return InterpolationValue(std::move(result));

@@ -24,7 +23,7 @@ InterpolationValue SVGNumberOptionalNumberInterpolationType::maybeConvertSVGValu

return nullptr;

const SVGNumberOptionalNumber& numberOptionalNumber = toSVGNumberOptionalNumber(svgValue);

- std::unique_ptr<InterpolableList> result = InterpolableList::create(2);

+ OwnPtr<InterpolableList> result = InterpolableList::create(2);

result->set(0, InterpolableNumber::create(numberOptionalNumber.firstNumber()->value()));

result->set(1, InterpolableNumber::create(numberOptionalNumber.secondNumber()->value()));

return InterpolationValue(std::move(result));