third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

index ce3a4786f4213e583275f9834c483b4fd8f6cf97..6fde06965dc87064506c44169b0bd9f009c72469 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

@@ -39,7 +39,6 @@

#include "modules/indexeddb/MockWebIDBDatabase.h"

#include "platform/SharedBuffer.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include <memory>

#include <v8.h>

namespace blink {

@@ -64,7 +63,7 @@ private:

TEST(IDBTransactionTest, EnsureLifetime)

{

V8TestingScope scope;

- std::unique_ptr<MockWebIDBDatabase> backend = MockWebIDBDatabase::create();

+ OwnPtr<MockWebIDBDatabase> backend = MockWebIDBDatabase::create();

EXPECT_CALL(*backend, close())

.Times(1);

Persistent<IDBDatabase> db = IDBDatabase::create(scope.getExecutionContext(), std::move(backend), FakeIDBDatabaseCallbacks::create());

@@ -99,7 +98,7 @@ TEST(IDBTransactionTest, TransactionFinish)

V8TestingScope scope;

const int64_t transactionId = 1234;

- std::unique_ptr<MockWebIDBDatabase> backend = MockWebIDBDatabase::create();

+ OwnPtr<MockWebIDBDatabase> backend = MockWebIDBDatabase::create();

EXPECT_CALL(*backend, commit(transactionId))

.Times(1);

EXPECT_CALL(*backend, close())