third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp

index 8685a8d9aef70f852faed223fb13b84ab091d650..e70381b628ca4af6e1f556a481295996b2cddb26 100644

--- a/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp

@@ -8,7 +8,6 @@

#include "core/animation/SVGLengthInterpolationType.h"

#include "core/animation/UnderlyingLengthChecker.h"

#include "core/svg/SVGLengthList.h"

-#include <memory>

namespace blink {

@@ -20,7 +19,7 @@ InterpolationValue SVGLengthListInterpolationType::maybeConvertNeutral(const Int

if (underlyingLength == 0)

return nullptr;

- std::unique_ptr<InterpolableList> result = InterpolableList::create(underlyingLength);

+ OwnPtr<InterpolableList> result = InterpolableList::create(underlyingLength);

for (size_t i = 0; i < underlyingLength; i++)

result->set(i, SVGLengthInterpolationType::neutralInterpolableValue());

return InterpolationValue(std::move(result));

@@ -32,7 +31,7 @@ InterpolationValue SVGLengthListInterpolationType::maybeConvertSVGValue(const SV

return nullptr;

const SVGLengthList& lengthList = toSVGLengthList(svgValue);

- std::unique_ptr<InterpolableList> result = InterpolableList::create(lengthList.length());

+ OwnPtr<InterpolableList> result = InterpolableList::create(lengthList.length());

for (size_t i = 0; i < lengthList.length(); i++) {

InterpolationValue component = SVGLengthInterpolationType::convertSVGLength(*lengthList.at(i));

result->set(i, std::move(component.interpolableValue));