third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp b/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

index c222134963b4c793666420e818aa7061eef6cd16..1e120bfe619fd546f75ca945b04274f62a495e20 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

@@ -24,7 +24,6 @@

#include "core/layout/svg/SVGResources.h"

#include "core/layout/svg/SVGResourcesCycleSolver.h"

#include "core/svg/SVGDocumentExtensions.h"

-#include <memory>

namespace blink {

@@ -44,7 +43,7 @@ void SVGResourcesCache::addResourcesFromLayoutObject(LayoutObject* object, const

const SVGComputedStyle& svgStyle = style.svgStyle();

// Build a list of all resources associated with the passed LayoutObject.

- std::unique_ptr<SVGResources> newResources = SVGResources::buildResources(object, svgStyle);

+ OwnPtr<SVGResources> newResources = SVGResources::buildResources(object, svgStyle);

if (!newResources)

return;

@@ -65,7 +64,7 @@ void SVGResourcesCache::addResourcesFromLayoutObject(LayoutObject* object, const

void SVGResourcesCache::removeResourcesFromLayoutObject(LayoutObject* object)

{

- std::unique_ptr<SVGResources> resources = m_cache.take(object);

+ OwnPtr<SVGResources> resources = m_cache.take(object);

if (!resources)

return;