third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp - Issue 2080623002: Revert "Remove OwnPtr from Blink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

index 63f41a4a172f49cda7e15b1886e18216634513f2..74e5a2b15f140262a7f93ea051011f596074a077 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

@@ -35,8 +35,6 @@

#include "public/platform/WebThread.h"

#include "public/platform/WebTraceLocation.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "wtf/PtrUtil.h"

-#include <memory>

namespace blink {

@@ -186,7 +184,7 @@ TEST_F(ImageFrameGeneratorTest, incompleteDecodeBecomesCompleteMultiThreaded)

// LocalFrame can now be decoded completely.

setFrameStatus(ImageFrame::FrameComplete);

addNewData();

- std::unique_ptr<WebThread> thread = wrapUnique(Platform::current()->createThread("DecodeThread"));

+ OwnPtr<WebThread> thread = adoptPtr(Platform::current()->createThread("DecodeThread"));

thread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&decodeThreadMain, m_generator, m_segmentReader));

thread.reset();

EXPECT_EQ(2, m_decodeRequestCount);