Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.h

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ReadableStreamDataConsumerHandle_h 5 #ifndef ReadableStreamDataConsumerHandle_h
6 #define ReadableStreamDataConsumerHandle_h 6 #define ReadableStreamDataConsumerHandle_h
7 7
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "modules/ModulesExport.h" 9 #include "modules/ModulesExport.h"
10 #include "modules/fetch/FetchDataConsumerHandle.h" 10 #include "modules/fetch/FetchDataConsumerHandle.h"
11 #include "wtf/Forward.h" 11 #include "wtf/Forward.h"
12 #include "wtf/PtrUtil.h" 12 #include "wtf/PassOwnPtr.h"
13 #include "wtf/RefPtr.h" 13 #include "wtf/RefPtr.h"
14 #include <memory>
15 14
16 namespace blink { 15 namespace blink {
17 16
18 class ScriptState; 17 class ScriptState;
19 18
20 // This class is a FetchDataConsumerHandle pulling bytes from ReadableStream 19 // This class is a FetchDataConsumerHandle pulling bytes from ReadableStream
21 // implemented with V8 Extras. 20 // implemented with V8 Extras.
22 // The stream will be immediately locked by the handle and will never be 21 // The stream will be immediately locked by the handle and will never be
23 // released. 22 // released.
24 // 23 //
25 // The ReadableStreamReader handle held in a ReadableStreamDataConsumerHandle 24 // The ReadableStreamReader handle held in a ReadableStreamDataConsumerHandle
26 // is weak. A user must guarantee that the ReadableStreamReader object is kept 25 // is weak. A user must guarantee that the ReadableStreamReader object is kept
27 // alive appropriately. 26 // alive appropriately.
28 // TODO(yhirano): CURRENTLY THIS HANDLE SUPPORTS READING ONLY FROM THE THREAD ON 27 // TODO(yhirano): CURRENTLY THIS HANDLE SUPPORTS READING ONLY FROM THE THREAD ON
29 // WHICH IT IS CREATED. FIX THIS. 28 // WHICH IT IS CREATED. FIX THIS.
30 class MODULES_EXPORT ReadableStreamDataConsumerHandle final : public FetchDataCo nsumerHandle { 29 class MODULES_EXPORT ReadableStreamDataConsumerHandle final : public FetchDataCo nsumerHandle {
31 WTF_MAKE_NONCOPYABLE(ReadableStreamDataConsumerHandle); 30 WTF_MAKE_NONCOPYABLE(ReadableStreamDataConsumerHandle);
32 public: 31 public:
33 static std::unique_ptr<ReadableStreamDataConsumerHandle> create(ScriptState* scriptState, ScriptValue streamReader) 32 static PassOwnPtr<ReadableStreamDataConsumerHandle> create(ScriptState* scri ptState, ScriptValue streamReader)
34 { 33 {
35 return wrapUnique(new ReadableStreamDataConsumerHandle(scriptState, stre amReader)); 34 return adoptPtr(new ReadableStreamDataConsumerHandle(scriptState, stream Reader));
36 } 35 }
37 ~ReadableStreamDataConsumerHandle() override; 36 ~ReadableStreamDataConsumerHandle() override;
38 37
39 private: 38 private:
40 class ReadingContext; 39 class ReadingContext;
41 ReadableStreamDataConsumerHandle(ScriptState*, ScriptValue streamReader); 40 ReadableStreamDataConsumerHandle(ScriptState*, ScriptValue streamReader);
42 Reader* obtainReaderInternal(Client*) override; 41 Reader* obtainReaderInternal(Client*) override;
43 const char* debugName() const override { return "ReadableStreamDataConsumerH andle"; } 42 const char* debugName() const override { return "ReadableStreamDataConsumerH andle"; }
44 43
45 RefPtr<ReadingContext> m_readingContext; 44 RefPtr<ReadingContext> m_readingContext;
46 }; 45 };
47 46
48 } // namespace blink 47 } // namespace blink
49 48
50 #endif // ReadableStreamDataConsumerHandle_h 49 #endif // ReadableStreamDataConsumerHandle_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698