Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/DataConsumerHandleUtil.h" 5 #include "modules/fetch/DataConsumerHandleUtil.h"
6 6
7 #include "platform/blob/BlobData.h" 7 #include "platform/blob/BlobData.h"
8 #include "public/platform/Platform.h" 8 #include "public/platform/Platform.h"
9 #include "public/platform/WebTaskRunner.h" 9 #include "public/platform/WebTaskRunner.h"
10 #include "public/platform/WebThread.h" 10 #include "public/platform/WebThread.h"
11 #include "public/platform/WebTraceLocation.h" 11 #include "public/platform/WebTraceLocation.h"
12 #include "wtf/Functional.h" 12 #include "wtf/Functional.h"
13 #include "wtf/PtrUtil.h"
14 #include <memory>
15 13
16 namespace blink { 14 namespace blink {
17 15
18 using Result = WebDataConsumerHandle::Result; 16 using Result = WebDataConsumerHandle::Result;
19 17
20 namespace { 18 namespace {
21 19
22 class WaitingHandle final : public WebDataConsumerHandle { 20 class WaitingHandle final : public WebDataConsumerHandle {
23 private: 21 private:
24 class ReaderImpl final : public WebDataConsumerHandle::Reader { 22 class ReaderImpl final : public WebDataConsumerHandle::Reader {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 }; 64 };
67 65
68 class UnexpectedErrorHandle final : public WebDataConsumerHandle { 66 class UnexpectedErrorHandle final : public WebDataConsumerHandle {
69 private: 67 private:
70 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(UnexpectedError, client); } 68 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(UnexpectedError, client); }
71 const char* debugName() const override { return "UnexpectedErrorHandle"; } 69 const char* debugName() const override { return "UnexpectedErrorHandle"; }
72 }; 70 };
73 71
74 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle { 72 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle {
75 public: 73 public:
76 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { } 74 WebToFetchDataConsumerHandleAdapter(PassOwnPtr<WebDataConsumerHandle> handle ) : m_handle(std::move(handle)) { }
77 private: 75 private:
78 class ReaderImpl final : public FetchDataConsumerHandle::Reader { 76 class ReaderImpl final : public FetchDataConsumerHandle::Reader {
79 public: 77 public:
80 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { } 78 ReaderImpl(PassOwnPtr<WebDataConsumerHandle::Reader> reader) : m_reader( std::move(reader)) { }
81 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride 79 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride
82 { 80 {
83 return m_reader->read(data, size, flags, readSize); 81 return m_reader->read(data, size, flags, readSize);
84 } 82 }
85 83
86 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride 84 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride
87 { 85 {
88 return m_reader->beginRead(buffer, flags, available); 86 return m_reader->beginRead(buffer, flags, available);
89 } 87 }
90 Result endRead(size_t readSize) override 88 Result endRead(size_t readSize) override
91 { 89 {
92 return m_reader->endRead(readSize); 90 return m_reader->endRead(readSize);
93 } 91 }
94 private: 92 private:
95 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader; 93 OwnPtr<WebDataConsumerHandle::Reader> m_reader;
96 }; 94 };
97 95
98 Reader* obtainReaderInternal(Client* client) override { return new ReaderImp l(m_handle->obtainReader(client)); } 96 Reader* obtainReaderInternal(Client* client) override { return new ReaderImp l(m_handle->obtainReader(client)); }
99 97
100 const char* debugName() const override { return m_handle->debugName(); } 98 const char* debugName() const override { return m_handle->debugName(); }
101 99
102 std::unique_ptr<WebDataConsumerHandle> m_handle; 100 OwnPtr<WebDataConsumerHandle> m_handle;
103 }; 101 };
104 102
105 } // namespace 103 } // namespace
106 104
107 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle() 105 PassOwnPtr<WebDataConsumerHandle> createWaitingDataConsumerHandle()
108 { 106 {
109 return wrapUnique(new WaitingHandle); 107 return adoptPtr(new WaitingHandle);
110 } 108 }
111 109
112 std::unique_ptr<WebDataConsumerHandle> createDoneDataConsumerHandle() 110 PassOwnPtr<WebDataConsumerHandle> createDoneDataConsumerHandle()
113 { 111 {
114 return wrapUnique(new DoneHandle); 112 return adoptPtr(new DoneHandle);
115 } 113 }
116 114
117 std::unique_ptr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle() 115 PassOwnPtr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle()
118 { 116 {
119 return wrapUnique(new UnexpectedErrorHandle); 117 return adoptPtr(new UnexpectedErrorHandle);
120 } 118 }
121 119
122 std::unique_ptr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHan dle(std::unique_ptr<WebDataConsumerHandle> handle) 120 PassOwnPtr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHandle(P assOwnPtr<WebDataConsumerHandle> handle)
123 { 121 {
124 return wrapUnique(new WebToFetchDataConsumerHandleAdapter(std::move(handle)) ); 122 return adoptPtr(new WebToFetchDataConsumerHandleAdapter(std::move(handle)));
125 } 123 }
126 124
127 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client) 125 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client)
128 : m_factory(this) 126 : m_factory(this)
129 { 127 {
130 if (!client) 128 if (!client)
131 return; 129 return;
132 // Note we don't need thread safety here because this object is 130 // Note we don't need thread safety here because this object is
133 // bound to the current thread. 131 // bound to the current thread.
134 Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FRO M_HERE, bind(&NotifyOnReaderCreationHelper::notify, m_factory.createWeakPtr(), c lient)); 132 Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FRO M_HERE, bind(&NotifyOnReaderCreationHelper::notify, m_factory.createWeakPtr(), c lient));
135 } 133 }
136 134
137 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client) 135 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client)
138 { 136 {
139 // |client| dereference is safe here because: 137 // |client| dereference is safe here because:
140 // - |this| is owned by a reader, 138 // - |this| is owned by a reader,
141 // so the reader outlives |this|, and 139 // so the reader outlives |this|, and
142 // - |client| is the client of the reader, so |client| outlives the reader 140 // - |client| is the client of the reader, so |client| outlives the reader
143 // (guaranteed by the user of the reader), 141 // (guaranteed by the user of the reader),
144 // and therefore |client| outlives |this|. 142 // and therefore |client| outlives |this|.
145 client->didGetReadable(); 143 client->didGetReadable();
146 } 144 }
147 145
148 } // namespace blink 146 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698