Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

Issue 2080623002: Revert "Remove OwnPtr from Blink." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/EffectInput.h" 5 #include "core/animation/EffectInput.h"
6 6
7 #include "bindings/core/v8/Dictionary.h" 7 #include "bindings/core/v8/Dictionary.h"
8 #include "bindings/core/v8/EffectModelOrDictionarySequenceOrDictionary.h" 8 #include "bindings/core/v8/EffectModelOrDictionarySequenceOrDictionary.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 #include "core/animation/KeyframeEffectModel.h" 11 #include "core/animation/KeyframeEffectModel.h"
12 #include "core/dom/Document.h" 12 #include "core/dom/Document.h"
13 #include "core/dom/Element.h" 13 #include "core/dom/Element.h"
14 #include "core/dom/ExceptionCode.h" 14 #include "core/dom/ExceptionCode.h"
15 #include "core/testing/DummyPageHolder.h" 15 #include "core/testing/DummyPageHolder.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include <memory>
18 #include <v8.h> 17 #include <v8.h>
19 18
20 namespace blink { 19 namespace blink {
21 20
22 Element* appendElement(Document& document) 21 Element* appendElement(Document& document)
23 { 22 {
24 Element* element = document.createElement("foo", ASSERT_NO_EXCEPTION); 23 Element* element = document.createElement("foo", ASSERT_NO_EXCEPTION);
25 document.documentElement()->appendChild(element); 24 document.documentElement()->appendChild(element);
26 return element; 25 return element;
27 } 26 }
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 jsKeyframes.append(Dictionary(keyframe2, scope.isolate(), scope.getException State())); 139 jsKeyframes.append(Dictionary(keyframe2, scope.isolate(), scope.getException State()));
141 jsKeyframes.append(Dictionary(keyframe3, scope.isolate(), scope.getException State())); 140 jsKeyframes.append(Dictionary(keyframe3, scope.isolate(), scope.getException State()));
142 141
143 Element* element = appendElement(scope.document()); 142 Element* element = appendElement(scope.document());
144 EffectInput::convert(element, EffectModelOrDictionarySequenceOrDictionary::f romDictionarySequence(jsKeyframes), nullptr, scope.getExceptionState()); 143 EffectInput::convert(element, EffectModelOrDictionarySequenceOrDictionary::f romDictionarySequence(jsKeyframes), nullptr, scope.getExceptionState());
145 EXPECT_TRUE(scope.getExceptionState().hadException()); 144 EXPECT_TRUE(scope.getExceptionState().hadException());
146 EXPECT_EQ(V8TypeError, scope.getExceptionState().code()); 145 EXPECT_EQ(V8TypeError, scope.getExceptionState().code());
147 } 146 }
148 147
149 } // namespace blink 148 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698