Quick View: Add a test that checks Quick View opens with Space key.

ui/file_manager/file_manager/background/js/test_util_base.js

Index: ui/file_manager/file_manager/background/js/test_util_base.js
diff --git a/ui/file_manager/file_manager/background/js/test_util_base.js b/ui/file_manager/file_manager/background/js/test_util_base.js
index 2bcb3af4a91bf0250b51a019457ef590cb526663..5d83979bc93b0fb45a0622f530b67ea65d748d16 100644
--- a/ui/file_manager/file_manager/background/js/test_util_base.js
+++ b/ui/file_manager/file_manager/background/js/test_util_base.js
@@ -26,6 +26,7 @@ function extractElementInfo(element, contentWindow, opt_styleNames) {
   }
   var styles = {};
   var styleNames = opt_styleNames || [];
+  assert(Array.isArray(styleNames));
   var computedStyles = contentWindow.getComputedStyle(element);
   for (var i = 0; i < styleNames.length; i++) {
     styles[styleNames[i]] = computedStyles[styleNames[i]];
@@ -223,31 +224,76 @@ test.util.sync.isWindowMaximized = function(contentWindow) {
 /**
  * Queries all elements.
  *
- * @param {Window} contentWindow Window to be tested.
+ * @param {!Window} contentWindow Window to be tested.
  * @param {string} targetQuery Query to specify the element.
  * @param {?string} iframeQuery Iframe selector or null if no iframe.
  * @param {Array<string>=} opt_styleNames List of CSS property name to be
  *     obtained.
- * @return {Array<{attributes:Object<string>, text:string,
+ * @return {!Array<{attributes:Object<string>, text:string,
  *                  styles:Object<string>, hidden:boolean}>} Element
  *     information that contains contentText, attribute names and
  *     values, hidden attribute, and style names and values.
  */
 test.util.sync.queryAllElements = function(
     contentWindow, targetQuery, iframeQuery, opt_styleNames) {
+  return test.util.sync.deepQueryAllElements(
+      contentWindow, [targetQuery], iframeQuery, opt_styleNames);
+};
+
+/**
+ * Queries elements inside shadow DOM.
+ *
+ * @param {!Window} contentWindow Window to be tested.
+ * @param {!Array<string>} targetQuery Query to specify the element.
+ *   |targetQuery[0]| specifies the first element(s). |targetQuery[1]| specifies
+ *   elements inside the shadow DOM of the first element, and so on.
+ * @param {?string} iframeQuery Iframe selector or null if no iframe.
+ * @param {Array<string>=} opt_styleNames List of CSS property name to be
+ *     obtained.
+ * @return {!Array<{attributes:Object<string>, text:string,
+ *                  styles:Object<string>, hidden:boolean}>} Element
+ *     information that contains contentText, attribute names and
+ *     values, hidden attribute, and style names and values.
+ */
+test.util.sync.deepQueryAllElements = function(
+    contentWindow, targetQuery, iframeQuery, opt_styleNames) {
   var doc = test.util.sync.getDocument_(
       contentWindow, iframeQuery || undefined);
   if (!doc)
     return [];
-  // The return value of querySelectorAll is not an array.
-  return Array.prototype.map.call(
-      doc.querySelectorAll(targetQuery),
-      function(element) {
-        return extractElementInfo(element, contentWindow, opt_styleNames);
+  var elems = test.util.sync.deepQuerySelectorAll_(doc, targetQuery);
+
+  return elems.map(function(element) {
+    return extractElementInfo(element, contentWindow, opt_styleNames);
       });

[fukino, 2016/08/15 02:02:08]

nit: correct the indent level.

[oka, 2016/08/15 06:03:41]

Done.

 };
 
 /**
+ * @param {(!HTMLElement|!Document)} root Element to search from.

[fukino, 2016/08/15 02:02:08]

nit: Add a one-line description for this method.

[oka, 2016/08/15 06:03:41]

Done.

+ * @param {!Array<string>} targetQuery Query to specify the element.
+ *   |targetQuery[0]| specifies the first element(s). |targetQuery[1]| specifies
+ *   elements inside the shadow DOM of the first element, and so on.
+ * @return {!Array<!HTMLElement>} Matched elements.
+ *
+ * @private
+ */
+test.util.sync.deepQuerySelectorAll_ = function(root, targetQuery) {
+  var elems = Array.prototype.slice.call(root.querySelectorAll(targetQuery[0]));
+  var remaining = targetQuery.slice(1);
+  if (remaining.length === 0)
+    return elems;
+
+  var res = [];
+  for (var i = 0; i < elems.length; i++) {
+    if (elems[i].shadowRoot) {
+      res = res.concat(
+          test.util.sync.deepQuerySelectorAll_(elems[i].shadowRoot, remaining));
+    }
+  }
+  return res;
+};
+
+/**
  * Get the information of the active element.
  *
  * @param {Window} contentWindow Window to be tested.