Quick View: Add a test that checks Quick View opens with Space key.

Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/bc6c6a9f8465205341712bf2cce55d80bfd9e666
Cr-Commit-Position: refs/heads/master@{#411943}

[oka, 2016-08-12 20:45:15]

Update

[oka, 2016-08-12 21:08:58]

nit

[oka, 2016-08-12 21:14:12]

nit

[oka, 2016-08-13 01:07:01]

nit

[oka, 2016-08-13 01:32:59]

Description was changed from

==========
WIP: QuicView: Add test.

BUG=613465
==========

to

==========
QuickView: Add test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

[oka, 2016-08-13 01:32:59]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-13 01:33:07]

PTAL.

[oka, 2016-08-13 01:35:48]

Description was changed from

==========
QuickView: Add test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

to

==========
QuickView: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

[oka, 2016-08-13 01:35:54]

Description was changed from

==========
QuickView: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

[oka, 2016-08-13 01:36:19]

nit

[oka, 2016-08-13 01:38:56]

nit

[oka, 2016-08-13 01:40:21]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-13 01:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 02:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:31:39]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-08-15 02:02:08]

lgtm with nits.

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
File ui/file_manager/file_manager/background/js/test_util_base.js (right):

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/test_util_base.js:268: });
nit: correct the indent level.

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/test_util_base.js:272: * @param
{(!HTMLElement|!Document)} root Element to search from.
nit: Add a one-line description for this method.

[oka, 2016-08-15 06:00:56]

nit

[oka, 2016-08-15 06:03:41]

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
File ui/file_manager/file_manager/background/js/test_util_base.js (right):

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/test_util_base.js:268: });
On 2016/08/15 02:02:08, fukino wrote:
> nit: correct the indent level.

Done.

https://codereview.chromium.org/2080613002/diff/140001/ui/file_manager/file_m...
ui/file_manager/file_manager/background/js/test_util_base.js:272: * @param
{(!HTMLElement|!Document)} root Element to search from.
On 2016/08/15 02:02:08, fukino wrote:
> nit: Add a one-line description for this method.

Done.

[oka, 2016-08-15 06:03:47]

The CQ bit was checked by oka@chromium.org

[oka, 2016-08-15 06:03:47]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2080613002/#ps160001
(title: "nit")

[commit-bot: I haz the power, 2016-08-15 06:03:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 06:46:07]

Description was changed from

==========
Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

[commit-bot: I haz the power, 2016-08-15 06:46:08]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-15 06:48:16]

Description was changed from

==========
Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add a test that checks Quick View opens with Space key.

BUG=613465
TEST=out/Release/browser_tests --gtest_filter="*/FileManagerBrowserTest.Test*"
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/bc6c6a9f8465205341712bf2cce55d80bfd9e666
Cr-Commit-Position: refs/heads/master@{#411943}
==========

[commit-bot: I haz the power, 2016-08-15 06:48:17]

Patchset 9 (id:??) landed as
https://crrev.com/bc6c6a9f8465205341712bf2cce55d80bfd9e666
Cr-Commit-Position: refs/heads/master@{#411943}