chrome/browser/ui/cocoa/notifications/notification_common.gyp - Issue 2080603004: Reland https://codereview.chromium.org/2080733002

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/notifications/notification_common.gyp

Issue 2080603004: Reland https://codereview.chromium.org/2080733002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 # GN version: //chrome/browser/ui/notifications:common

	9 'target_name': 'notification_common',

	10 'type': 'static_library',

	11 'include_dirs': [

	12 '<(DEPTH)',

	13 ],

	14 'sources': [

	15 'notification_builder_mac.h',

	16 'notification_builder_mac.mm',

	17 ],

	18 'deps': [

	19 '//base',

	20 '//chrome:strings',

	21 '//ui/base:base',
	Peter Beverloo 2016/06/20 18:54:23 This isn't how gyp works... Did you test it? Thes This isn't how gyp works... Did you test it? These have to be absolute references to the gyp files, relative from the path of the current directory. For example: <(DEPTH)/base/base.gyp:base ... Miguel Garcia 2016/06/21 11:25:42 Done. Show quoted text On 2016/06/20 18:54:23, Peter Beverloo wrote: > This isn't how gyp works... Did you test it? > > These have to be absolute references to the gyp files, relative from the path of > the current directory. For example: > > <(DEPTH)/base/base.gyp:base > ... Done.
	22 ]

	23 },

	24 ],

	25 }
	Peter Beverloo 2016/06/20 18:54:23 Repeated since you didn't apply it in the previous Repeated since you didn't apply it in the previous CL (please confirm before uploading): micro nits: (a) no blank line on :6, (b) 2-space indent on :7, (c) +2-space indent elsewhere, (d) everything in gyp ends with a comma (:22) Miguel Garcia 2016/06/21 11:25:42 Done. Show quoted text On 2016/06/20 18:54:23, Peter Beverloo wrote: > Repeated since you didn't apply it in the previous CL (please confirm before > uploading): > > micro nits: (a) no blank line on :6, (b) 2-space indent on :7, (c) +2-space > indent elsewhere, (d) everything in gyp ends with a comma (:22) Done.
OLD	NEW

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »