third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 2080593002: Revert of Let FrameView track object paint invalidations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2080593002: Revert of Let FrameView track object paint invalidations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TrackInvalidation

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 45536cf559320bc491f520d02da65a33ef28093a..02a8c9acce0f77460fd29ab3e092589bec20c118 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -2829,9 +2829,9 @@

m_paintInvalidationLogicalBottom = LayoutUnit();

}

-void LayoutBlockFlow::invalidateDisplayItemClients(PaintInvalidationReason invalidationReason) const

- LayoutBlock::invalidateDisplayItemClients(invalidationReason);

+void LayoutBlockFlow::invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidationContainer, PaintInvalidationReason invalidationReason) const

+ LayoutBlock::invalidateDisplayItemClients(paintInvalidationContainer, invalidationReason);

// If the block is a continuation or containing block of an inline continuation, invalidate the

// start object of the continuations if it has focus ring because change of continuation may change

@@ -2849,7 +2849,7 @@

startOfContinuations = firstChild->node()->layoutObject();

}

if (startOfContinuations && startOfContinuations->styleRef().outlineStyleIsAuto())

- startOfContinuations->slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*startOfContinuations, invalidationReason);

+ startOfContinuations->invalidateDisplayItemClient(*startOfContinuations);

}

void LayoutBlockFlow::clearFloats(EClear clear)