Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2080573002: [ieee754] Use uint32_t/uint64_t instead of u_int32_t/u_int64_t. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ieee754] Use uint32_t/uint64_t instead of u_int32_t/u_int64_t. The uint32_t/uint64_t types are more portable than the old style, pre C99 u_int32_t/u_int64_t types. R=yangguo@chromium.org BUG=v8:5086 Committed: https://crrev.com/3c9ff7ecf875bf604a809943a27dae1a1a9c556f Cr-Commit-Position: refs/heads/master@{#37088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -31 lines) Patch
M src/base/ieee754.cc View 18 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-20 06:27:54 UTC) #1
Benedikt Meurer
Hey Yang, Here's the fixup for the uint types. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-20 06:29:48 UTC) #3
Yang
On 2016/06/20 06:29:48, Benedikt Meurer wrote: > Hey Yang, > > Here's the fixup for ...
4 years, 6 months ago (2016-06-20 06:32:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080573002/1
4 years, 6 months ago (2016-06-20 06:32:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 06:56:32 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c9ff7ecf875bf604a809943a27dae1a1a9c556f Cr-Commit-Position: refs/heads/master@{#37088}
4 years, 6 months ago (2016-06-20 06:57:08 UTC) #9
Mostyn Bramley-Moore
4 years, 6 months ago (2016-06-20 08:01:03 UTC) #10
Message was sent while issue was closed.
lgtm, tested on some of my older targets.

Powered by Google App Engine
This is Rietveld 408576698