Issue 2080563003: (Merge m52) Fix a bug with throttling and timer queue suspension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2080563003: (Merge m52) Fix a bug with throttling and timer queue suspension (Closed)

Created:
4 years, 6 months ago by alex clarke (OOO till 29th)

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

(Merge m52) Fix a bug with throttling and timer queue suspension Both the ThrottlingHelper and timer queue suspension (via SuspendTimerQueue/ResumeTimerQueue and SuspendTimerQueueWhenBackgrounded / ResumeTimerQueueWhenForegrounded) call TaskQueue::SetEnabled and it was possible for the ThrottlingHelper to re-enable a suspended queue by mistake. This patch prevents that from happening. BUG=616052 Review-Url: https://codereview.chromium.org/2028433004 Cr-Commit-Position: refs/heads/master@{#397437} (cherry picked from commit 22ca5b9bce1453364fdb32979af7175ccf234e15)

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -12 lines)			Patch
M	components/scheduler/renderer/renderer_scheduler_impl.cc	View	5 chunks	+15 lines, -5 lines	0 comments	Download
M	components/scheduler/renderer/renderer_scheduler_impl_unittest.cc	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	components/scheduler/renderer/throttling_helper.h	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	components/scheduler/renderer/throttling_helper.cc	View	3 chunks	+25 lines, -5 lines	0 comments	Download
M	components/scheduler/renderer/throttling_helper_unittest.cc	View	2 chunks	+48 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

alex clarke (OOO till 29th)

4 years, 6 months ago (2016-06-20 17:22:39 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
4d2936fe75fce2a1fe1e8af63da34a7898d0a5dd.

Expand Messages | Collapse Messages