bluetooth: Enable Web Bluetooth in Origin Trials

bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported platforms.
Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8

TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1b1ccbb74c918f7c3b52a9b41db67873788136d2
Cr-Commit-Position: refs/heads/master@{#402575}

[ortuno, 2016-06-23 21:08:15]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Unavailable".

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
==========

[ortuno, 2016-06-23 21:23:17]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
==========

[ortuno, 2016-06-23 21:24:01]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ortuno, 2016-06-23 21:25:01]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On a Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On a Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ortuno, 2016-06-23 21:37:46]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 21:38:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080553002/100001

[ortuno, 2016-06-23 22:45:49]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-06-23 22:45:50]

scheib: PTAL

[commit-bot: I haz the power, 2016-06-24 00:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 00:28:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-06-24 00:57:48]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org, iclelland@chromium.org

[haraken, 2016-06-24 00:57:49]

bindings/ LGTM. It would be great if we could auto-generate the installation
code but that would be a separate issue.

[iclelland, 2016-06-24 03:37:23]

LGTM, just a couple of comment nits. Thanks!

haraken -- totally agree that this needs to be generated code soon. I'll start
working on that patch.

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
(right):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:579:
originTrialContext->setFeatureBindingsInstalled("WebBluetooth");
Just a note, that if  https://codereview.chromium.org/2096663002/ lands before
this patch, you'll need to move this line into bindings/core/v8/V8Bindings.cpp
(and if this one lands first, I'll take care of it)

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // only support
Chrome OS and Android for this experiment we reject any
OS X is also supported, right?

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl (left):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl:10: //
[OriginTrialEnabled] doesn't support adding bindings to partial
Can you add this comment back in? We're close to fixing that bug, and I'd like
to have the note here so that I can easily find it and fix this interface when
the fix lands.

[ortuno, 2016-06-24 16:01:31]

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
(right):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp:579:
originTrialContext->setFeatureBindingsInstalled("WebBluetooth");
On 2016/06/24 at 03:37:23, iclelland wrote:
> Just a note, that if  https://codereview.chromium.org/2096663002/ lands before
this patch, you'll need to move this line into bindings/core/v8/V8Bindings.cpp
(and if this one lands first, I'll take care of it)

My reviewer is out until tuesday, so your patch will probably land first :) I'll
make the change once your patch lands.

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // only support
Chrome OS and Android for this experiment we reject any
On 2016/06/24 at 03:37:23, iclelland wrote:
> OS X is also supported, right?

Ah, I did change this to include macOS, but push off on uploading the patch
because of CQ. Done.

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl (left):

https://codereview.chromium.org/2080553002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl:10: //
[OriginTrialEnabled] doesn't support adding bindings to partial
On 2016/06/24 at 03:37:23, iclelland wrote:
> Can you add this comment back in? We're close to fixing that bug, and I'd like
to have the note here so that I can easily find it and fix this interface when
the fix lands.

Done.

[ortuno, 2016-06-24 16:01:35]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 16:02:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-06-24 18:30:47]

haraken, iclelland: I rebased and updated the bindings code, PTAL.

[ortuno, 2016-06-24 18:30:52]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 18:32:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2016-06-24 18:36:32]

LGTM, thanks!

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // origin trial
token. Since we only support Chrome OS, Android and macOS
nit: MacOS

[ortuno, 2016-06-24 19:16:33]

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // origin trial
token. Since we only support Chrome OS, Android and macOS
On 2016/06/24 at 18:36:32, iclelland wrote:
> nit: MacOS

I think it's macOS, like in iOS O_O.
https://9to5mac.files.wordpress.com/2016/06/wwdc-2016-watchos-tvos-macos-ios....

[iclelland, 2016-06-24 19:46:36]

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // origin trial
token. Since we only support Chrome OS, Android and macOS
On 2016/06/24 19:16:33, ortuno wrote:
> On 2016/06/24 at 18:36:32, iclelland wrote:
> > nit: MacOS
> 
> I think it's macOS, like in iOS O_O.
>
https://9to5mac.files.wordpress.com/2016/06/wwdc-2016-watchos-tvos-macos-ios....

Maybe --or Mac OS X, or MacOSX, or just 'OS X' ;)
(Even more authoritatively,
https://web.archive.org/web/20160624143934/https://developer.apple.com/macos/ )

I went for consistency in the codebase -- 702 results at
https://cs.chromium.org/search/?q=MacOS+case:yes&sq=package:chromium&type=cs
versus 3 for
https://cs.chromium.org/search/?q=macOS+case:yes&sq=package:chromium&type=cs

But it's a nit, so I'm really not going to rescind an l g t m over it :)

[ortuno, 2016-06-27 20:22:42]

Oops. Seems like I forgot to send drafts :) Thanks!

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2080553002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:136: // origin trial
token. Since we only support Chrome OS, Android and macOS
On 2016/06/24 at 19:46:35, iclelland wrote:
> On 2016/06/24 19:16:33, ortuno wrote:
> > On 2016/06/24 at 18:36:32, iclelland wrote:
> > > nit: MacOS
> > 
> > I think it's macOS, like in iOS O_O.
> >
https://9to5mac.files.wordpress.com/2016/06/wwdc-2016-watchos-tvos-macos-ios....
> 
> Maybe --or Mac OS X, or MacOSX, or just 'OS X' ;)
> (Even more authoritatively,
https://web.archive.org/web/20160624143934/https://developer.apple.com/macos/ )
> 
> I went for consistency in the codebase -- 702 results at
> https://cs.chromium.org/search/?q=MacOS+case:yes&sq=package:chromium&type=cs
> versus 3 for
> https://cs.chromium.org/search/?q=macOS+case:yes&sq=package:chromium&type=cs
> 
> But it's a nit, so I'm really not going to rescind an l g t m over it :)

Ah I guess we are not using the new name yet. I'll change to match the rest of
the codebase.

[scheib, 2016-06-28 19:38:12]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present" and "Use Web Bluetooth"
should
   be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present" and "Use Web Bluetooth" should
   be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".


Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[scheib, 2016-06-28 19:47:42]

LGTM

[ortuno, 2016-06-28 19:48:35]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-06-28 19:48:36]

Thanks!

[ortuno, 2016-06-28 19:48:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/2080553002/#ps180001
(title: "Change to MacOS")

[commit-bot: I haz the power, 2016-06-28 19:49:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:56:27]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ortuno, 2016-06-28 20:52:52]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:54:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 21:10:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 21:10:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2016-06-28 21:21:05]

ortuno@chromium.org changed reviewers:
+ alexmos@chromium.org

[ortuno, 2016-06-28 21:21:06]

alexmos: PTAL at content/b/f/render_frame_host_impl.cc

[alexmos, 2016-06-28 21:25:41]

render_frame_host_impl.cc LGTM

[ortuno, 2016-06-28 21:32:59]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-06-28 21:33:00]

wow that was fast! Thanks!

[commit-bot: I haz the power, 2016-06-28 21:34:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:39:09]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".


Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".


Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-28 22:39:11]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-06-28 22:41:39]

Description was changed from

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8


TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".


Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
bluetooth: Enable Web Bluetooth in Origin Trials

This enables Web Bluetooth through experimental frameworks in supported
platforms.
Intent to Experiment:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8

TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1b1ccbb74c918f7c3b52a9b41db67873788136d2
Cr-Commit-Position: refs/heads/master@{#402575}
==========

[commit-bot: I haz the power, 2016-06-28 22:41:40]

Patchset 10 (id:??) landed as
https://crrev.com/1b1ccbb74c918f7c3b52a9b41db67873788136d2
Cr-Commit-Position: refs/heads/master@{#402575}