Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 208053004: Oilpan: "Move" ElementStyleResources to the oilpan heap. (Closed)

Created:
6 years, 9 months ago by wibling-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Oilpan: "Move" ElementStyleResources to the oilpan heap. ElementStyleResources are only allocated as a part object of another stack allocated object so we don't need to use persistent heap collections as the entries will be marked conservatively via the stack. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169838

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/css/resolver/CSSToStyleMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
wibling-chromium
6 years, 9 months ago (2014-03-21 13:46:25 UTC) #1
haraken
LGTM https://codereview.chromium.org/208053004/diff/1/Source/core/css/resolver/ElementStyleResources.h File Source/core/css/resolver/ElementStyleResources.h (right): https://codereview.chromium.org/208053004/diff/1/Source/core/css/resolver/ElementStyleResources.h#newcode51 Source/core/css/resolver/ElementStyleResources.h:51: WTF_MAKE_NONCOPYABLE(ElementStyleResources); Nit: Fix indentation.
6 years, 9 months ago (2014-03-21 13:51:29 UTC) #2
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-24 06:45:11 UTC) #3
wibling-chromium
Thanks for the reviews! https://codereview.chromium.org/208053004/diff/1/Source/core/css/resolver/ElementStyleResources.h File Source/core/css/resolver/ElementStyleResources.h (right): https://codereview.chromium.org/208053004/diff/1/Source/core/css/resolver/ElementStyleResources.h#newcode51 Source/core/css/resolver/ElementStyleResources.h:51: WTF_MAKE_NONCOPYABLE(ElementStyleResources); On 2014/03/21 13:51:30, haraken ...
6 years, 9 months ago (2014-03-24 07:59:17 UTC) #4
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 9 months ago (2014-03-24 08:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/208053004/1
6 years, 9 months ago (2014-03-24 08:58:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 08:59:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 08:59:13 UTC) #8
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 9 months ago (2014-03-24 09:11:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/208053004/1
6 years, 9 months ago (2014-03-24 09:11:14 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 10:02:21 UTC) #11
Message was sent while issue was closed.
Change committed as 169838

Powered by Google App Engine
This is Rietveld 408576698