Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: mojo/public/cpp/bindings/tests/connector_unittest.cc

Issue 2080513002: Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/connector_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/connector_unittest.cc b/mojo/public/cpp/bindings/tests/connector_unittest.cc
index 810ab8b88fcd138b89dc7fadb12a4403049652cf..0a81c9b85843f6b3bac8bb87de87e4a927663952 100644
--- a/mojo/public/cpp/bindings/tests/connector_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/connector_unittest.cc
@@ -10,6 +10,8 @@
#include <utility>
#include "base/bind.h"
+#include "base/callback.h"
+#include "base/callback_helpers.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -24,15 +26,13 @@ namespace {
class MessageAccumulator : public MessageReceiver {
public:
MessageAccumulator() {}
- explicit MessageAccumulator(const Closure& closure) : closure_(closure) {}
+ explicit MessageAccumulator(const base::Closure& closure)
+ : closure_(closure) {}
bool Accept(Message* message) override {
queue_.Push(message);
- if (!closure_.is_null()) {
- Closure closure = closure_;
- closure_.Reset();
- closure.Run();
- }
+ if (!closure_.is_null())
+ base::ResetAndReturn(&closure_).Run();
return true;
}
@@ -40,13 +40,13 @@ class MessageAccumulator : public MessageReceiver {
void Pop(Message* message) { queue_.Pop(message); }
- void set_closure(const Closure& closure) { closure_ = closure; }
+ void set_closure(const base::Closure& closure) { closure_ = closure; }
size_t size() const { return queue_.size(); }
private:
MessageQueue queue_;
- Closure closure_;
+ base::Closure closure_;
};
class ConnectorDeletingMessageAccumulator : public MessageAccumulator {
« no previous file with comments | « mojo/public/cpp/bindings/tests/bindings_perftest.cc ('k') | mojo/public/cpp/bindings/tests/handle_passing_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698