Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 208043002: Mark CollectCpuProfile as flaky. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Mark CollectCpuProfile as flaky. R=machenbach@chromium.org BUG=v8:2999 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20157

Patch Set 1 #

Patch Set 2 : flaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-21 11:34:32 UTC) #1
Michael Achenbach
I think you can keep the PASS FAIL expectations where they were. I remember this ...
6 years, 9 months ago (2014-03-21 11:37:53 UTC) #2
Michael Achenbach
lgtm
6 years, 9 months ago (2014-03-21 11:43:30 UTC) #3
Yang
6 years, 9 months ago (2014-03-21 11:46:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698