Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2080423002: Remove calls to MessageLoop::current() in ipc. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in ipc. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=jam@chromium.org Committed: https://crrev.com/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86 Cr-Commit-Position: refs/heads/master@{#400762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M ipc/ipc_logging.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_logging.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
lgtm
4 years, 6 months ago (2016-06-20 19:34:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080423002/1
4 years, 6 months ago (2016-06-20 19:41:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 20:24:33 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 20:28:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcb9b32ec79d574c921ba5ad8b9405d99d9d5f86
Cr-Commit-Position: refs/heads/master@{#400762}

Powered by Google App Engine
This is Rietveld 408576698