Added the next series of files that go into media-internals.

content/browser/resources/media/new/main.js

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * A global object that gets used by the C++ interface.
+ */
+var media = (function() {
+  'use strict';
+
+  var doNothing = function() {
+  };
+  var mockRenderManager = {
+    redrawList: doNothing,
+    update: doNothing,
+    select: doNothing
+  };
+
+  var manager = new PlayerManager((typeof RenderManager !== 'undefined') ?
+    new RenderManager : mockRenderManager);

[scherkus (not reviewing), 2013/07/29 20:35:54]

this is a very subtle way of injecting a mock that relies on *not* including
RenderManager code prior to this code

OOC, if this is used for the integration test should we be mocking out more
functionality? what's stopping us from using the real RenderManager?

[Ty Overby, 2013/07/29 21:53:31]

Because RenderManager depends on every "yet to be added" file in the project, so
I'd either have to remove 80% of the code in the file or mock it.

+
+  /**
+   * Call to modify or add a system property

[scherkus (not reviewing), 2013/07/29 20:35:54]

periods on comments here + below

[Ty Overby, 2013/07/29 21:53:31]

Done.

+   */
+  function onSystemProperty(timestamp, key, value) {
+    console.log('System properties not yet implemented');
+  }
+
+  /**
+   * Call to modify or add a property on a player
+   */
+  function onPlayerProperty(id, timestamp, key, value) {
+    manager.updatePlayerInfo(id, timestamp, key, value);
+  }
+
+  function onPlayerPropertyNoRecord(id, timestamp, key, value) {
+    manager.updatePlayerInfoNoRecord(id, timestamp, key, value);
+  }
+
+  /**
+   * Call to add a player.
+   */
+  function onPlayerOpen(id, timestamp) {
+    manager.addPlayer(id, timestamp);
+  }
+
+  /**
+   * Call to remove a player.
+   */
+  function onPlayerClose(id) {
+    manager.removePlayer(id);
+  }
+
+  var media = {
+    onSystemProperty: onSystemProperty,
+    onPlayerProperty: onPlayerProperty,
+    onPlayerPropertyNoRecord: onPlayerPropertyNoRecord,
+    onPlayerOpen: onPlayerOpen,
+    onPlayerClose: onPlayerClose,
+    manager: manager
+  };
+
+  // Everything beyond this point is for backwards

[scherkus (not reviewing), 2013/07/29 20:35:54]

try to use more chars per-line (up to 80) if you can

[Ty Overby, 2013/07/29 21:53:31]

Done.

+  // compatibility reasons.  It will go away when
+  // the backend is updated.
+
+  media.onNetUpdate = function(update) {
+    // TODO(tyoverby): Implement
+  };
+
+  media.onRendererTerminated = function(renderId) {
+    goog.object.forEach(manager.players_, function(playerInfo, id) {
+      if (playerInfo.properties['render_id'] == renderId) {
+        media.onPlayerClose(id);
+      }
+    });
+  };
+
+  // For whatever reason, addAudioStream is also called on
+  // the removal of audio streams.
+  media.addAudioStream = function(event) {
+    switch (event.status) {
+      case 'created':
+        media.onPlayerOpen(event.id);
+        // We have to simulate the timestamp since
+        // it isn't provided to us.
+        media.onPlayerProperty(event.id, (new Date()).getTime(),
+          'playing', event.playing);

[scherkus (not reviewing), 2013/07/29 20:35:54]

indentation for any continued line gets either:
  1) A 4-space indent if there's no preceeding parameter OR
  2) Aligned to the opening ( if there are preceeding parameter

check out style guide for some detailed examples:
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Code_fo...

but basically, the following are all acceptable forms

foo.onBar(arg1, arg2, arg3);

foo.onBar(arg1, arg2,
          arg3);

foo.onBar(arg1,
          arg2,
          arg3);

foo.onBar(  /* NOTE: no arg here! */
    arg1, arg2, arg3);

foo.onBar(  /* NOTE: no arg here! */
    arg1, arg2,
    arg3);

foo.onBar(  /* NOTE: no arg here! */
    arg1,
    arg2,
    arg3);

+        break;
+      case 'closed':
+        media.onPlayerClose(event.id);
+        break;
+    }
+  };
+  media.onItemDeleted = function() {
+    // This only gets called when an audio stream is removed, which
+    // for whatever reason is also handled by addAudioStream...
+    // Because it is already handled, we can safely ignore it.
+  };
+
+  media.onMediaEvent = function(event) {
+    var source = event.renderer + ':' + event.player;
+
+    // Although this gets called on every event, there
+    // is nothing we can do about this because there is no onOpen event.
+    media.onPlayerOpen(source);
+    media.onPlayerPropertyNoRecord(source, event.ticksMillis, 'render_id',
+      event.renderer);

[scherkus (not reviewing), 2013/07/29 20:35:54]

ditto

[Ty Overby, 2013/07/29 21:53:31]

Done.

+    media.onPlayerPropertyNoRecord(source, event.ticksMillis, 'player_id',
+      event.player);

[scherkus (not reviewing), 2013/07/29 20:35:54]

ditto

[Ty Overby, 2013/07/29 21:53:31]

Done.

+
+    var propertyCount = 0;
+    goog.object.forEach(event.params, function(value, key) {
+      key = key.trim();
+      if (key === 'buffer_start' || key === 'buffer_end' ||
+        key === 'buffer_current' || key === 'is_downloading_data') {

[scherkus (not reviewing), 2013/07/29 20:35:54]

same style rules apply here - this should be aligned at (

[Ty Overby, 2013/07/29 21:53:31]

Done.

+        media.onPlayerPropertyNoRecord(source, event.ticksMillis, key,
+          value);
+      } else {
+        media.onPlayerProperty(source, event.ticksMillis, key, value);
+      }
+      propertyCount += 1;
+    });
+
+    if (propertyCount === 0) {
+      media.onPlayerProperty(source, event.ticksMillis, 'EVENT',
+        event.type);

[scherkus (not reviewing), 2013/07/29 20:35:54]

ditto

[Ty Overby, 2013/07/29 21:53:31]

Done.

+    }
+  };
+
+  return media;
+}());