Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Side by Side Diff: content/browser/resources/media/new/util.js

Issue 20804002: Added the next series of files that go into media-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5
scherkus (not reviewing) 2013/07/29 23:09:23 remove extra blank line
Ty Overby 2013/07/29 23:26:56 Done.
6 /**
7 * @fileoverview Some utility functions that don't belong anywhere else in the
8 * code.
9 */
10
11 var util = {};
12 util.object = {};
scherkus (not reviewing) 2013/07/29 23:09:23 nit: I'd drop the .object sub-module namespace
Ty Overby 2013/07/29 23:26:56 I disagree. Usually forEach is defined on arrays/
scherkus (not reviewing) 2013/07/29 23:55:18 SGTM
13 util.object.forEach = function(obj, f, optObj) {
scherkus (not reviewing) 2013/07/29 23:09:23 docs on functions
Ty Overby 2013/07/29 23:26:56 Done.
14 'use strict';
15 var key;
16 for (key in obj) {
17 if (obj.hasOwnProperty(key)) {
18 f.call(optObj, obj[key], key, obj);
19 }
20 }
21 };
22
scherkus (not reviewing) 2013/07/29 23:09:23 remove extra blank line
Ty Overby 2013/07/29 23:26:56 Done.
OLDNEW
« content/browser/resources/media/new/main.js ('K') | « content/browser/resources/media/new/main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698