Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 208040: Remove all direct references to NavigationController from the RenderViewHostM... (Closed)

Created:
11 years, 3 months ago by Daniel
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Remove all direct references to NavigationController from the RenderViewHostManager::Delegate class--shunt all direct uses of NavigationController through the Delegate abstraction to be implement in TabContents by adding some additional functions that need implementation in the RenderViewHostManager::Delegate class. These functions include virtual Profile* GetProfileForRenderManager () const=0; virtual NavigationEntry* GetEntryAtOffsetForRenderManager(int offset)=0; virtual void NotifyRenderViewHostSwitchedFromRenderManager(RenderViewHostSwitchedDetails*details)=0; BUG=22356 TEST=write an abstraction that implements the RenderViewHostManager::Delegate without referencing TabContents classes

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M AUTHORS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.h View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.cc View 1 2 5 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698