Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2080383003: Make OutOfMemory test work on 32 bit machines. (Closed)

Created:
4 years, 6 months ago by cbernaschina
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed unnecessary print #

Patch Set 3 : Explained how we obtain the OutOfMemoryError on all platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart View 1 2 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 6 months ago (2016-06-21 00:15:07 UTC) #2
cbernaschina
4 years, 6 months ago (2016-06-21 00:17:07 UTC) #3
rmacnak
lgtm w/c https://codereview.chromium.org/2080383003/diff/1/runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart File runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart (right): https://codereview.chromium.org/2080383003/diff/1/runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart#newcode13 runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart:13: List<List> out = <List>[]; Add a comment ...
4 years, 6 months ago (2016-06-21 00:18:35 UTC) #4
cbernaschina
4 years, 6 months ago (2016-06-21 00:26:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
05f3bc28238d7568f9bb68e2d88068ebc924e056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698