Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2080383002: cc/ipc: Move CompositorFrame mojoms (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc/ipc: Move CompositorFrame mojoms This CL moves some mojom structs around for readability in anticipation of being able to serialize CompositorFrames over mojo. 1. RenderPass moves out of quads.mojom as quads_struct_traits was growing very rapidly. RenderPass StructTraits will come in a subsequent CL. 2. compositor_frame.mojom moved to cc/ipc with the rest of the cc mojoms 3. Remaining components/mus/public/interfaces/compositor_frame.mojom moved to surface.mojom to clarify functionality. BUG=611802 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/caa652befe567c179c2a501aed75ba86202a5343 Cr-Commit-Position: refs/heads/master@{#400956}

Patch Set 1 #

Patch Set 2 : Updated owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -88 lines) Patch
M cc/ipc/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A cc/ipc/compositor_frame.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
M cc/ipc/quads.mojom View 2 chunks +0 lines, -11 lines 0 comments Download
A cc/ipc/render_pass.mojom View 1 chunk +22 lines, -0 lines 0 comments Download
M components/bitmap_uploader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/gpu/display_compositor/compositor_frame_sink_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/tests/surface_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D components/mus/public/interfaces/compositor_frame.mojom View 1 chunk +0 lines, -34 lines 0 comments Download
A + components/mus/public/interfaces/gpu/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M components/mus/public/interfaces/gpu/display_compositor.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/mus/public/interfaces/surface.mojom View 2 chunks +2 lines, -14 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_window_surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Fady Samuel
+meacer@ for ipc (this is just moving some structs around). +ajuma@ for cc overall +ben@ ...
4 years, 6 months ago (2016-06-20 18:57:14 UTC) #3
meacer
IPC lgtm
4 years, 6 months ago (2016-06-20 19:15:09 UTC) #4
ajuma
cc lgtm
4 years, 6 months ago (2016-06-20 19:58:56 UTC) #5
Fady Samuel
PTAL Ben! Thanks
4 years, 6 months ago (2016-06-20 20:43:44 UTC) #6
Fady Samuel
Ben, I'm going to TBR you since this is largely mus code that I own, ...
4 years, 6 months ago (2016-06-21 01:20:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080383002/1
4 years, 6 months ago (2016-06-21 01:21:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/203817)
4 years, 6 months ago (2016-06-21 01:29:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080383002/20001
4 years, 6 months ago (2016-06-21 10:56:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 11:48:00 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 11:49:58 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/caa652befe567c179c2a501aed75ba86202a5343
Cr-Commit-Position: refs/heads/master@{#400956}

Powered by Google App Engine
This is Rietveld 408576698