Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2080353002: Reapply "Background finalization." (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Background finalization." This reverts commit 7d9e75e0b6c64f60b031b7711f8505a1239d99fa. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d265a3db53d15a7739dae4567b64363a46baa056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -44 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 12 chunks +34 lines, -13 lines 0 comments Download
M runtime/vm/dart_api_state.h View 8 chunks +54 lines, -12 lines 0 comments Download
A runtime/vm/dart_api_state.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M runtime/vm/gc_marker.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M runtime/vm/heap.h View 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M runtime/vm/profiler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/scavenger.cc View 4 chunks +16 lines, -6 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
This CL had been reverted because of a failure (double-free?) in malloc on the bots. ...
4 years, 6 months ago (2016-06-20 17:43:06 UTC) #2
siva
lgtm
4 years, 6 months ago (2016-06-21 15:42:10 UTC) #3
rmacnak
4 years, 6 months ago (2016-06-21 16:27:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d265a3db53d15a7739dae4567b64363a46baa056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698