Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2080343003: Remove calls to MessageLoop::current() in remoting. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
Sergey Ulanov, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in remoting. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=garykac@chromium.org Committed: https://crrev.com/10eaa01bf64c5dad1cb2a216803fbe3680672d34 Cr-Commit-Position: refs/heads/master@{#401042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M remoting/host/setup/start_host_main.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-21 17:21:55 UTC) #1
Sergey Ulanov
lgtm
4 years, 6 months ago (2016-06-21 17:28:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080343003/1
4 years, 6 months ago (2016-06-21 17:29:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 18:03:51 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 18:16:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10eaa01bf64c5dad1cb2a216803fbe3680672d34
Cr-Commit-Position: refs/heads/master@{#401042}

Powered by Google App Engine
This is Rietveld 408576698