Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2080313004: Add manifest.json to Flash output for Mac. (Closed)

Created:
4 years, 6 months ago by waffles
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
Will Harris, Sorin Jianu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add manifest.json to Flash output for Mac. This file is needed to unify how the updater finds the version on disk as well as a base for differential updates. BUG=601928 Committed: https://crrev.com/58f1f45cb86735c30e2787358cd3a0827fc8cde4 Cr-Commit-Position: refs/heads/master@{#401016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
waffles
thestig: PTAL at this small CL that adds Flash's manifest.json into the official build output ...
4 years, 6 months ago (2016-06-21 00:25:15 UTC) #2
Lei Zhang
On 2016/06/21 00:25:15, waffles wrote: > thestig: PTAL at this small CL that adds Flash's ...
4 years, 6 months ago (2016-06-21 07:22:57 UTC) #3
waffles
On 2016/06/21 07:22:57, Lei Zhang wrote: > On 2016/06/21 00:25:15, waffles wrote: > > thestig: ...
4 years, 6 months ago (2016-06-21 15:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080313004/1
4 years, 6 months ago (2016-06-21 15:58:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 16:49:08 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:55:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58f1f45cb86735c30e2787358cd3a0827fc8cde4
Cr-Commit-Position: refs/heads/master@{#401016}

Powered by Google App Engine
This is Rietveld 408576698