Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2080303003: aura: Introduce EnvInputStateController for updating Env input states. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura: Introduce EnvInputStateController for updating Env input states. aura::Env stores some information about the input events (e.g. the latest location of the mouse cursor, current event-flags, whethere there is any active touch point). Move the code that updates these states out of WindowEventDispatcher into EnvInputStateController, so that it can be used in NativeWidgetMus to update the Env states (since NativeWidgetMus will directly dispatch events to Widget, and so WindowEventDispatcher will not be used). BUG=616101 Committed: https://crrev.com/9d8d13f5ea46d5f5450aecc28edb3c9613977fd8 Cr-Commit-Position: refs/heads/master@{#400813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -62 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura/env_input_state_controller.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ui/aura/env_input_state_controller.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 4 chunks +3 lines, -5 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 10 chunks +13 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
4 years, 6 months ago (2016-06-20 20:05:38 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-20 21:54:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080303003/1
4 years, 6 months ago (2016-06-20 22:27:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 22:33:22 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:39:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d8d13f5ea46d5f5450aecc28edb3c9613977fd8
Cr-Commit-Position: refs/heads/master@{#400813}

Powered by Google App Engine
This is Rietveld 408576698