Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2080283002: Implement GetCounterTextFromResult() for the hosted apps counter. (Closed)

Created:
4 years, 6 months ago by msramek
Modified:
4 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, ioanap
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement GetCounterTextFromResult() for the hosted apps counter. Possible outputs are: - "none" - "1 app (<example>)" - "2 apps (<example 1>, <example 2>)" - "X apps (<example 1>, <example 2>, and X-2 more)" Since this is rather complex, also add a unittest. BUG=510028 Committed: https://crrev.com/9d6006cd757f9d25828e6af2dfde77dd814ccdb6 Cr-Commit-Position: refs/heads/master@{#400681}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Total comments: 4

Patch Set 3 : Fixed compilation errors. #

Patch Set 4 : Fixed cast type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M chrome/browser/browsing_data/browsing_data_counter_utils.cc View 1 2 3 2 chunks +44 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc View 1 2 4 chunks +55 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
msramek
Hi Václav, Can you please have a look? You reviewed my CL where these strings ...
4 years, 6 months ago (2016-06-20 13:42:28 UTC) #3
msramek
+Ioana FYI in case this causes a merge conflict.
4 years, 6 months ago (2016-06-20 13:43:37 UTC) #4
vabr (Chromium)
LGTM. Cheers, Vaclav https://codereview.chromium.org/2080283002/diff/20001/chrome/browser/browsing_data/browsing_data_counter_utils.cc File chrome/browser/browsing_data/browsing_data_counter_utils.cc (right): https://codereview.chromium.org/2080283002/diff/20001/chrome/browser/browsing_data/browsing_data_counter_utils.cc#newcode171 chrome/browser/browsing_data/browsing_data_counter_utils.cc:171: DCHECK_GE((unsigned int)hosted_apps_result->Value(), Please do not use ...
4 years, 6 months ago (2016-06-20 13:51:43 UTC) #5
msramek
Thanks Václav! https://codereview.chromium.org/2080283002/diff/20001/chrome/browser/browsing_data/browsing_data_counter_utils.cc File chrome/browser/browsing_data/browsing_data_counter_utils.cc (right): https://codereview.chromium.org/2080283002/diff/20001/chrome/browser/browsing_data/browsing_data_counter_utils.cc#newcode171 chrome/browser/browsing_data/browsing_data_counter_utils.cc:171: DCHECK_GE((unsigned int)hosted_apps_result->Value(), On 2016/06/20 13:51:43, vabr (Chromium) ...
4 years, 6 months ago (2016-06-20 14:06:19 UTC) #6
vabr (Chromium)
Still LGTM. Cheers, Vaclav https://codereview.chromium.org/2080283002/diff/40001/chrome/browser/browsing_data/browsing_data_counter_utils.cc File chrome/browser/browsing_data/browsing_data_counter_utils.cc (right): https://codereview.chromium.org/2080283002/diff/40001/chrome/browser/browsing_data/browsing_data_counter_utils.cc#newcode173 chrome/browser/browsing_data/browsing_data_counter_utils.cc:173: base::checked_cast<HostedAppsCounter::ResultInt>( BrowsingDataCounter::ResultInt https://codereview.chromium.org/2080283002/diff/40001/chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc File chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc ...
4 years, 6 months ago (2016-06-20 14:16:50 UTC) #7
msramek
I fixed compilation errors which were caused by one oversight, but more importantly, by the ...
4 years, 6 months ago (2016-06-20 14:17:39 UTC) #8
vabr (Chromium)
On 2016/06/20 14:17:39, msramek wrote: > I fixed compilation errors which were caused by one ...
4 years, 6 months ago (2016-06-20 14:38:20 UTC) #9
msramek
Thanks again! Will land this now. https://codereview.chromium.org/2080283002/diff/40001/chrome/browser/browsing_data/browsing_data_counter_utils.cc File chrome/browser/browsing_data/browsing_data_counter_utils.cc (right): https://codereview.chromium.org/2080283002/diff/40001/chrome/browser/browsing_data/browsing_data_counter_utils.cc#newcode173 chrome/browser/browsing_data/browsing_data_counter_utils.cc:173: base::checked_cast<HostedAppsCounter::ResultInt>( On 2016/06/20 ...
4 years, 6 months ago (2016-06-20 14:41:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080283002/80001
4 years, 6 months ago (2016-06-20 14:41:16 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 6 months ago (2016-06-20 15:36:35 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:37:53 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9d6006cd757f9d25828e6af2dfde77dd814ccdb6
Cr-Commit-Position: refs/heads/master@{#400681}

Powered by Google App Engine
This is Rietveld 408576698