Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/about_flags.cc

Issue 2080263002: Change fill-on-account-select to use Features API, not a custom flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused GRD strings Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 075118b733f851fe339d8dc357481d9c5ddb311b..415f0addbd8580d71af599460e699d82b5d92d35 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -357,14 +357,6 @@ const FeatureEntry::Choice kExtensionContentVerificationChoices[] = {
switches::kExtensionContentVerificationEnforceStrict },
};
-const FeatureEntry::Choice kFillOnAccountSelectChoices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
- autofill::switches::kDisableFillOnAccountSelect, "" },
- { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_HIGHLIGHTING,
- autofill::switches::kEnableFillOnAccountSelect, "" },
-};
-
const FeatureEntry::Choice kTopChromeMaterialDesignChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_TOP_CHROME_MD_NON_MATERIAL,
@@ -1430,9 +1422,6 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-touch-hover", IDS_FLAGS_TOUCH_HOVER_NAME,
IDS_FLAGS_TOUCH_HOVER_DESCRIPTION, kOsAndroid,
SINGLE_VALUE_TYPE("enable-touch-hover")},
- {"enable-fill-on-account-select", IDS_FILL_ON_ACCOUNT_SELECT_NAME,
- IDS_FILL_ON_ACCOUNT_SELECT_DESCRIPTION, kOsAll,
- MULTI_VALUE_TYPE(kFillOnAccountSelectChoices)},
#if defined(OS_CHROMEOS)
{"enable-wifi-credential-sync", // FLAGS:RECORD_UMA
IDS_FLAGS_WIFI_CREDENTIAL_SYNC_NAME,
@@ -1927,6 +1916,9 @@ const FeatureEntry kFeatureEntries[] = {
SINGLE_VALUE_TYPE(chromeos::switches::kEnableEolNotification)},
#endif // defined(OS_CHROMEOS)
+ {"fill-on-account-select", IDS_FILL_ON_ACCOUNT_SELECT_NAME,
+ IDS_FILL_ON_ACCOUNT_SELECT_DESCRIPTION, kOsAll,
+ FEATURE_VALUE_TYPE(password_manager::features::kFillOnAccountSelect)},
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698