Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2080263002: Change fill-on-account-select to use Features API, not a custom flag (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change fill-on-account-select to use Features API, not a custom flag Previously, the fill-on-account-select experiment in the password manager had used a custom flag and Finch to manage the experiment. This updates the experiment to use the Features API which handles all of that automagically. Note: This is an updated copy of jww's https://codereview.chromium.org/2066703004/. Patch set 1 is equal to the approved patch set 3 of that CL, and patch set 2 here addresses jochen@'s comment from that CL. BUG=568713 TBR=jww@chromium.org, jochen@chromium.org Committed: https://crrev.com/6bf3a25d4e161cd1e19ced863e7c202398697b9b Cr-Commit-Position: refs/heads/master@{#400677}

Patch Set 1 : https://codereview.chromium.org/2066703004/ rebased #

Patch Set 2 : Remove unused GRD strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -70 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 10 chunks +17 lines, -16 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_manager_unittest.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M components/password_manager/core/common/password_manager_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/common/password_manager_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vabr (Chromium)
Remove unused GRD strings
4 years, 6 months ago (2016-06-20 12:33:16 UTC) #1
vabr (Chromium)
As explained in https://codereview.chromium.org/2066703004/#msg27, I rebased jww's approved CL, addressed Jochen's comment, and now I'm ...
4 years, 6 months ago (2016-06-20 12:34:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080263002/20001
4 years, 6 months ago (2016-06-20 12:35:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/230777)
4 years, 6 months ago (2016-06-20 13:48:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080263002/20001
4 years, 6 months ago (2016-06-20 13:53:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 14:26:57 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 14:28:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6bf3a25d4e161cd1e19ced863e7c202398697b9b
Cr-Commit-Position: refs/heads/master@{#400677}

Powered by Google App Engine
This is Rietveld 408576698