Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2080253006: Speculative fix for flaky telemetry test many_images.html (Closed)

Created:
4 years, 6 months ago by Justin Novosad
Modified:
4 years, 6 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for flaky telemetry test many_images.html Suspecting that the large working set of images is causing the test to be flaky due to memory pressure. Downsizing the test to see if that improves the situation. BUG=605553 Committed: https://crrev.com/e3027aee6c26b221e9b04705949feccca11a9b96 Cr-Commit-Position: refs/heads/master@{#400993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/page_sets/tough_canvas_cases/many_images/many_images.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Justin Novosad
PTAL
4 years, 6 months ago (2016-06-21 13:56:33 UTC) #2
sullivan
lgtm
4 years, 6 months ago (2016-06-21 13:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080253006/1
4 years, 6 months ago (2016-06-21 13:58:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 14:54:06 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:58:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3027aee6c26b221e9b04705949feccca11a9b96
Cr-Commit-Position: refs/heads/master@{#400993}

Powered by Google App Engine
This is Rietveld 408576698