src/heap/objects-visiting.cc - Issue 2080243003: Use instance type in Object.prototype.toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting.cc

Issue 2080243003: Use instance type in Object.prototype.toString(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add TODO comment about checking IsArray() before reading toStringTag. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/objects-visiting.cc

diff --git a/src/heap/objects-visiting.cc b/src/heap/objects-visiting.cc

index 19b204dbf7ddb2af2e8a6c81e5336f6e128a7713..83e2e1c820295b7f66d933ee1d5bb0f629bb8181 100644

--- a/src/heap/objects-visiting.cc

+++ b/src/heap/objects-visiting.cc

@@ -103,6 +103,8 @@ StaticVisitorBase::VisitorId StaticVisitorBase::GetVisitorId(

return kVisitJSArrayBuffer;

case JS_OBJECT_TYPE:

+ case JS_ERROR_TYPE:

+ case JS_ARGUMENTS_TYPE:

case JS_CONTEXT_EXTENSION_OBJECT_TYPE:

case JS_GENERATOR_OBJECT_TYPE:

case JS_MODULE_TYPE:

« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »