Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/heap/objects-visiting.cc

Issue 2080243003: Use instance type in Object.prototype.toString(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add TODO comment about checking IsArray() before reading toStringTag. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/objects-visiting.h" 5 #include "src/heap/objects-visiting.h"
6 6
7 #include "src/heap/mark-compact-inl.h" 7 #include "src/heap/mark-compact-inl.h"
8 #include "src/heap/objects-visiting-inl.h" 8 #include "src/heap/objects-visiting-inl.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric, 96 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
97 instance_size, has_unboxed_fields); 97 instance_size, has_unboxed_fields);
98 98
99 case SYMBOL_TYPE: 99 case SYMBOL_TYPE:
100 return kVisitSymbol; 100 return kVisitSymbol;
101 101
102 case JS_ARRAY_BUFFER_TYPE: 102 case JS_ARRAY_BUFFER_TYPE:
103 return kVisitJSArrayBuffer; 103 return kVisitJSArrayBuffer;
104 104
105 case JS_OBJECT_TYPE: 105 case JS_OBJECT_TYPE:
106 case JS_ERROR_TYPE:
107 case JS_ARGUMENTS_TYPE:
106 case JS_CONTEXT_EXTENSION_OBJECT_TYPE: 108 case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
107 case JS_GENERATOR_OBJECT_TYPE: 109 case JS_GENERATOR_OBJECT_TYPE:
108 case JS_MODULE_TYPE: 110 case JS_MODULE_TYPE:
109 case JS_VALUE_TYPE: 111 case JS_VALUE_TYPE:
110 case JS_DATE_TYPE: 112 case JS_DATE_TYPE:
111 case JS_ARRAY_TYPE: 113 case JS_ARRAY_TYPE:
112 case JS_GLOBAL_PROXY_TYPE: 114 case JS_GLOBAL_PROXY_TYPE:
113 case JS_GLOBAL_OBJECT_TYPE: 115 case JS_GLOBAL_OBJECT_TYPE:
114 case JS_MESSAGE_OBJECT_TYPE: 116 case JS_MESSAGE_OBJECT_TYPE:
115 case JS_TYPED_ARRAY_TYPE: 117 case JS_TYPED_ARRAY_TYPE:
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 }; 358 };
357 359
358 360
359 template Object* VisitWeakList<Context>(Heap* heap, Object* list, 361 template Object* VisitWeakList<Context>(Heap* heap, Object* list,
360 WeakObjectRetainer* retainer); 362 WeakObjectRetainer* retainer);
361 363
362 template Object* VisitWeakList<AllocationSite>(Heap* heap, Object* list, 364 template Object* VisitWeakList<AllocationSite>(Heap* heap, Object* list,
363 WeakObjectRetainer* retainer); 365 WeakObjectRetainer* retainer);
364 } // namespace internal 366 } // namespace internal
365 } // namespace v8 367 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698