Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2080233002: [turbofan] Properly lower NumberTan to Float64Tan. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly lower NumberTan to Float64Tan. TBR=mvstanton@chromium.org BUG=v8:5086, v8:5126 Committed: https://crrev.com/04c982af1e18cef4e0b22360b67e51b18447ccaf Cr-Commit-Position: refs/heads/master@{#37100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/representation-change.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-20 11:03:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080233002/1
4 years, 6 months ago (2016-06-20 11:03:30 UTC) #3
mvstanton
lgtm
4 years, 6 months ago (2016-06-20 11:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080233002/1
4 years, 6 months ago (2016-06-20 11:03:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 11:27:34 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 11:29:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04c982af1e18cef4e0b22360b67e51b18447ccaf
Cr-Commit-Position: refs/heads/master@{#37100}

Powered by Google App Engine
This is Rietveld 408576698