Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2080223010: cc: Clean up root_layer code in LTI (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 5 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, weiliangc, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up root_layer code in LTI This CL : 1) Stop setting root_layer in LTI::SetRootLayerForLayerList and renames it to OnCanDrawStateChangedForTree. 2) Add a new LTI::SetRootLayerForLayerListForTesting 3) Make LTI::root_layer() return layer_list[0] 4) Rename : root_layer_ -> root_layer_for_testing_, SetRootLayer -> SetRootLayerForTesting, root_layer() -> root_layer_for_testing() BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac Cr-Commit-Position: refs/heads/master@{#402390}

Patch Set 1 #

Patch Set 2 : "rename" #

Patch Set 3 : "ForTesting" #

Patch Set 4 : "Fortesting" #

Patch Set 5 : "rebase" #

Patch Set 6 : Reset root in detach #

Patch Set 7 : compile perftest #

Patch Set 8 : rebase++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -470 lines) Patch
M cc/input/scrollbar_animation_controller_linear_fade_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/input/scrollbar_animation_controller_thinning_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 2 3 4 5 chunks +13 lines, -10 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_list_iterator_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_utils_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 3 4 6 chunks +13 lines, -10 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_test_common.h View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 4 135 chunks +137 lines, -136 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 74 chunks +120 lines, -103 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 13 chunks +55 lines, -34 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 2 3 4 6 chunks +10 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 3 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_picture.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_video.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 6 chunks +16 lines, -13 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 2 3 38 chunks +61 lines, -46 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 2 3 17 chunks +23 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
jaydasika
PTAL (Patch 3 and 4 are only adding ForTesting suffix)
4 years, 6 months ago (2016-06-25 01:46:41 UTC) #6
ajuma
lgtm
4 years, 5 months ago (2016-06-27 15:23:30 UTC) #7
jaydasika
vollick : Can you review changes to platform/graphics ?
4 years, 5 months ago (2016-06-27 16:05:51 UTC) #8
Ian Vollick
On 2016/06/27 at 16:05:51, jaydasika wrote: > vollick : Can you review changes to platform/graphics ...
4 years, 5 months ago (2016-06-27 23:24:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080223010/100001
4 years, 5 months ago (2016-06-27 23:26:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/196440)
4 years, 5 months ago (2016-06-27 23:44:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080223010/120001
4 years, 5 months ago (2016-06-27 23:57:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/225672)
4 years, 5 months ago (2016-06-28 00:14:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080223010/140001
4 years, 5 months ago (2016-06-28 00:24:00 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/87668)
4 years, 5 months ago (2016-06-28 01:34:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2080223010/140001
4 years, 5 months ago (2016-06-28 01:57:40 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 5 months ago (2016-06-28 03:40:14 UTC) #28
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 03:43:22 UTC) #30
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/bf1875afad559e02cb26093ccbba79bbcfa9fcac
Cr-Commit-Position: refs/heads/master@{#402390}

Powered by Google App Engine
This is Rietveld 408576698