Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2080223009: X87: [stubs] Remove N-argument Hydrogen-based Array constructor stub. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Remove N-argument Hydrogen-based Array constructor stub. port c8ac0d8693f559795eeb3f3aaf386dde166fb2ab(r36888) original commit message: Instead, always tail call to the runtime. Also, cleanup the various versions of the runtime call that is used for Array construction fallback. There can be only one. BUG= Committed: https://crrev.com/5f28e5a9cd585eb83877b9424b1524312166be67 Cr-Commit-Position: refs/heads/master@{#37243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -84 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 7 chunks +18 lines, -64 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-24 09:11:22 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-24 09:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080223009/1
4 years, 6 months ago (2016-06-24 09:13:10 UTC) #6
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-24 09:25:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 09:37:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 09:38:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f28e5a9cd585eb83877b9424b1524312166be67
Cr-Commit-Position: refs/heads/master@{#37243}

Powered by Google App Engine
This is Rietveld 408576698