Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2080223006: [wasm] Move the semaphore for parallel compilation to the wasm module. (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move the semaphore for parallel compilation to the wasm module. If the semaphore is stored as a local variable in {CompileInParallel}, then the semaphore was sometimes deallocated too early and caused the compilation tasks to crash. This only happens with libc-2.19, libc-2.21 fixes the problem. R=mlippautz@chromium.org, rossberg@chromium.org Committed: https://crrev.com/d4d470326668a69a3d00cae51ae96d375f862d95 Cr-Commit-Position: refs/heads/master@{#37183}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adjusted a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/base/platform/semaphore.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 6 months ago (2016-06-22 10:00:46 UTC) #1
Michael Lippautz
lgtm from my side https://codereview.chromium.org/2080223006/diff/1/src/base/platform/semaphore.cc File src/base/platform/semaphore.cc (right): https://codereview.chromium.org/2080223006/diff/1/src/base/platform/semaphore.cc#newcode104 src/base/platform/semaphore.cc:104: // This check may fail ...
4 years, 6 months ago (2016-06-22 10:34:47 UTC) #2
rossberg
lgtm
4 years, 6 months ago (2016-06-22 11:12:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080223006/20001
4 years, 6 months ago (2016-06-22 11:26:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 11:28:26 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 11:31:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4d470326668a69a3d00cae51ae96d375f862d95
Cr-Commit-Position: refs/heads/master@{#37183}

Powered by Google App Engine
This is Rietveld 408576698