Revert of Fixing renderer's access to a file from HTTP POST (after a xsite transfer).

Revert of Fixing renderer's access to a file from HTTP POST (after a xsite transfer). (patchset #11 id:200001 of https://codereview.chromium.org/2062523002/ )

Reason for revert:
New test is failing on DrMemory:

First failing build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%281%29/builds/8084

Sample output:
CrossSiteTransferTest.PostWithFileData:

c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(458): error: Value of: delegate->file_chosen()
Actual: false
Expected: true
[2980:4872:0617/180652:2750297:WARNING:render_frame_host_impl.cc(1927)] OnDidStopLoading was called twice.
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(480): error: Value of: ChildProcessSecurityPolicyImpl::GetInstance()->CanReadFile( new_process_id, file_path)
Actual: false
Expected: true
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(490): error: Value of: actual_page_body
Expected: has substring "test-file-content"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition: form-data; name=\"file\"; filename=\"\"\nContent-Type: application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(492): error: Value of: actual_page_body
Expected: has substring "3488.tmp"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition: form-data; name=\"file\"; filename=\"\"\nContent-Type: application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"

Original issue's description:
> Fixing renderer's access to a file from HTTP POST (after a xsite transfer).
> 
> Renderer needs to access files from HTTP POST (i.e. from XSSAuditor).
> This CL makes sure that file access is preserved across xsite transfers.
> 
> BUG=101395, 613260
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/bd82f922853ea6e61c4d907f2b51786f3ed9f5a2
> Cr-Commit-Position: refs/heads/master@{#400460}

TBR=creis@chromium.org,lukasza@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=101395, 613260

[benwells, 2016-06-20 10:56:59]

The CQ bit was checked by benwells@chromium.org

[benwells, 2016-06-20 10:57:00]

Created Revert of Fixing renderer's access to a file from HTTP POST (after a
xsite transfer).

[commit-bot: I haz the power, 2016-06-20 10:57:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080223002/1

[commit-bot: I haz the power, 2016-06-20 10:58:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 10:58:52]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[benwells, 2016-06-20 12:08:10]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2016-06-20 12:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080223002/1

[commit-bot: I haz the power, 2016-06-20 12:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 12:09:53]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-06-20 16:54:33]

Ben,

I don't think this revert will apply cleanly (without also reverting some
dependent CLs).  OTOH, I see that you've already (thanks!) added an exception in
https://codereview.chromium.org/2084533002, so maybe I can just fix
https://crbug.com/621466 (hopefully I can land a fix today or tomorrow).

Pleas let me know if the above sounds good.  (or if the memory issue introduced
by my CL is still impacting other's ability to land and test their CLs).

[benwells, 2016-06-21 06:30:40]

On 2016/06/20 16:54:33, Łukasz Anforowicz wrote:
> Ben,
> 
> I don't think this revert will apply cleanly (without also reverting some
> dependent CLs).  OTOH, I see that you've already (thanks!) added an exception
in
> https://codereview.chromium.org/2084533002, so maybe I can just fix
> https://crbug.com/621466 (hopefully I can land a fix today or tomorrow).
> 
> Pleas let me know if the above sounds good.  (or if the memory issue
introduced
> by my CL is still impacting other's ability to land and test their CLs).

Yep, as reverting was complicated I just disabled the test on that bug. If you
could identify / fix the memory issue / broken test and re-enable the test ASAP
that would be great, thanks.

[Charlie Reis, 2016-06-21 18:13:21]

Description was changed from

==========
Revert of Fixing renderer's access to a file from HTTP POST (after a xsite
transfer). (patchset #11 id:200001 of
https://codereview.chromium.org/2062523002/ )

Reason for revert:
New test is failing on DrMemory:

First failing build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%2...

Sample output:
CrossSiteTransferTest.PostWithFileData:

c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(458):
error: Value of: delegate->file_chosen()
Actual: false
Expected: true
[2980:4872:0617/180652:2750297:WARNING:render_frame_host_impl.cc(1927)]
OnDidStopLoading was called twice.
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(480):
error: Value of: ChildProcessSecurityPolicyImpl::GetInstance()->CanReadFile(
new_process_id, file_path)
Actual: false
Expected: true
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(490):
error: Value of: actual_page_body
Expected: has substring "test-file-content"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition:
form-data; name=\"file\"; filename=\"\"\nContent-Type:
application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(492):
error: Value of: actual_page_body
Expected: has substring "3488.tmp"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition:
form-data; name=\"file\"; filename=\"\"\nContent-Type:
application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"

Original issue's description:
> Fixing renderer's access to a file from HTTP POST (after a xsite transfer).
> 
> Renderer needs to access files from HTTP POST (i.e. from XSSAuditor).
> This CL makes sure that file access is preserved across xsite transfers.
> 
> BUG=101395, 613260
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/bd82f922853ea6e61c4d907f2b51786f3ed9f5a2
> Cr-Commit-Position: refs/heads/master@{#400460}

TBR=creis@chromium.org,lukasza@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=101395, 613260
==========

to

==========
Revert of Fixing renderer's access to a file from HTTP POST (after a xsite
transfer). (patchset #11 id:200001 of
https://codereview.chromium.org/2062523002/ )

Reason for revert:
New test is failing on DrMemory:

First failing build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%2...

Sample output:
CrossSiteTransferTest.PostWithFileData:

c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(458):
error: Value of: delegate->file_chosen()
Actual: false
Expected: true
[2980:4872:0617/180652:2750297:WARNING:render_frame_host_impl.cc(1927)]
OnDidStopLoading was called twice.
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(480):
error: Value of: ChildProcessSecurityPolicyImpl::GetInstance()->CanReadFile(
new_process_id, file_path)
Actual: false
Expected: true
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(490):
error: Value of: actual_page_body
Expected: has substring "test-file-content"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition:
form-data; name=\"file\"; filename=\"\"\nContent-Type:
application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"
c:\b\build\slave\drm-cr\build\src\content\browser\cross_site_transfer_browsertest.cc(492):
error: Value of: actual_page_body
Expected: has substring "3488.tmp"
Actual: "------WebKitFormBoundary8oQLaVhRjyBKYRPr\nContent-Disposition:
form-data; name=\"file\"; filename=\"\"\nContent-Type:
application/octet-stream\n\n\n------WebKitFormBoundary8oQLaVhRjyBKYRPr--\n\n"

Original issue's description:
> Fixing renderer's access to a file from HTTP POST (after a xsite transfer).
> 
> Renderer needs to access files from HTTP POST (i.e. from XSSAuditor).
> This CL makes sure that file access is preserved across xsite transfers.
> 
> BUG=101395, 613260
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/bd82f922853ea6e61c4d907f2b51786f3ed9f5a2
> Cr-Commit-Position: refs/heads/master@{#400460}

TBR=creis@chromium.org,lukasza@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=101395, 613260
==========