Fix int64 lowering on big-endian architectures.

Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717

Committed: https://crrev.com/42ac51c82e34bc47fd751f15fcb915d5a2b15fe6
Cr-Commit-Position: refs/heads/master@{#37213}

[ivica.bogosavljevic, 2016-06-21 13:22:04]

Description was changed from

==========
Fix int64 lowering on big-endian architectures

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=
==========

to

==========
Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717
==========

[ivica.bogosavljevic, 2016-06-21 13:22:50]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, titzer@chromium.org

[ivica.bogosavljevic, 2016-06-21 13:22:50]

PTAL

[titzer, 2016-06-21 21:22:59]

https://codereview.chromium.org/2080213004/diff/1/src/compiler/int64-lowering.cc
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/2080213004/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.cc:120: #if defined(V8_TARGET_LITTLE_ENDIAN)
Can you factor this out into a common subroutine?

https://codereview.chromium.org/2080213004/diff/1/src/compiler/int64-lowering.h
File src/compiler/int64-lowering.h (right):

https://codereview.chromium.org/2080213004/diff/1/src/compiler/int64-lowering...
src/compiler/int64-lowering.h:29: static int GetLowerWordOffset() {
Can you move these into the CC file?

[ivica.bogosavljevic, 2016-06-22 09:11:00]

Fixed all, PTAL

[titzer, 2016-06-22 16:03:09]

lgtm modulo final suggestion

https://codereview.chromium.org/2080213004/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/2080213004/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:116: int Int64Lowering::GetLowerWordOffset() {
Can you go all the way and make these simple static constants in this file?

[ivica.bogosavljevic, 2016-06-23 10:56:54]

https://codereview.chromium.org/2080213004/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/2080213004/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:116: int Int64Lowering::GetLowerWordOffset() {
On 2016/06/22 16:03:09, titzer wrote:
> Can you go all the way and make these simple static constants in this file?

Acknowledged.

[ivica.bogosavljevic, 2016-06-23 10:56:59]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 10:57:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080213004/40001

[commit-bot: I haz the power, 2016-06-23 11:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 11:35:31]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-06-23 11:37:52]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[ivica.bogosavljevic, 2016-06-23 11:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2080213004/#ps40001
(title: "Use constants instead of get methods")

[commit-bot: I haz the power, 2016-06-23 11:37:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080213004/40001

[commit-bot: I haz the power, 2016-06-23 11:40:26]

Description was changed from

==========
Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717
==========

to

==========
Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717
==========

[commit-bot: I haz the power, 2016-06-23 11:40:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 11:41:16]

Description was changed from

==========
Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717
==========

to

==========
Fix int64 lowering on big-endian architectures.

Lowering of Int64Load, Int64Store, BitcastInt64ToFloat64 and
BitcastFloat64ToInt64 was using LE word ordering in memory,
causing failures on some tests.

BUG=mjsunit/regress/regress-599719,mjsunit/regress/regress-599717

Committed: https://crrev.com/42ac51c82e34bc47fd751f15fcb915d5a2b15fe6
Cr-Commit-Position: refs/heads/master@{#37213}
==========

[commit-bot: I haz the power, 2016-06-23 11:41:17]

Patchset 3 (id:??) landed as
https://crrev.com/42ac51c82e34bc47fd751f15fcb915d5a2b15fe6
Cr-Commit-Position: refs/heads/master@{#37213}